Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

See which models don't need setters #92

Open
2 tasks
stefandoorn opened this issue Jul 1, 2019 · 1 comment
Open
2 tasks

See which models don't need setters #92

stefandoorn opened this issue Jul 1, 2019 · 1 comment
Milestone

Comments

@stefandoorn
Copy link
Owner

It might be good to move away from model setters where possible, in case the data can be provided via the constructor. It improves immutability, as long as we keep extensibility in the implementation layer.

  • Identify models / setters
  • Adjust models
@loevgaard
Copy link
Collaborator

I think optional attributes should be nullable. As mentioned before in the future we will probably implement an event system where users can plug in to events. These events will likely carry these objects and hence they user will be able to modify the objects as per their use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants