Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Picture returned for User and Gifts #18

Open
steampoweredtaco opened this issue Oct 6, 2024 · 0 comments
Open

No Picture returned for User and Gifts #18

steampoweredtaco opened this issue Oct 6, 2024 · 0 comments
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers

Comments

@steampoweredtaco
Copy link
Owner

The issue appears to be in most (if not all?) cases we are only getting the thumbnails for the user's associated with the gift event. However, the library is too strict about checking for another size version of the picture, doesn't find it, and makes the event have a null picture value.

The desired outcome is to add members to the User event that can represent all the image size options that maybe return so library users may check for any size/type that might be available.

Ideally we will also have a helper method on the type, such as "GetBestPictureOption()" that will return the largest and common format (such as png > jpeg > webp)... etc

@steampoweredtaco steampoweredtaco added bug Something isn't working enhancement New feature or request good first issue Good for newcomers labels Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant