Merge pull request #23 from steamclock/jc/22-fix-retain-cycle

[22] Fix retain cycle
steamclock · May 13, 2020 · b067a19 · b067a19
2 parents 4047599 + 63268fd
commit b067a19
Show file tree

Hide file tree

Showing 5 changed files with 40 additions and 32 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,9 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
+## [1.3.1] - 2020-05-12
+- Fix view controller retain cycle
+
 ## [1.3.0] - 2020-03-18
 - Update for Swift 5
 - Add SPM support

diff --git a/Example/Pods/Pods.xcodeproj/project.pbxproj b/Example/Pods/Pods.xcodeproj/project.pbxproj
diff --git a/Example/Pods/Target Support Files/Switchcraft/Switchcraft-Info.plist b/Example/Pods/Target Support Files/Switchcraft/Switchcraft-Info.plist
diff --git a/Sources/Switchcraft/Switchcraft.swift b/Sources/Switchcraft/Switchcraft.swift
@@ -351,7 +351,11 @@ public class Switchcraft {
      * - returns: The new `UITapGestureRecognizer`.
      */
     private func makeDefaultGestureRecognizer(forVC viewController: UIViewController) -> UITapGestureRecognizer {
-        showSwitcher = { self.display(from: viewController) }
+        showSwitcher = { [weak viewController] in
+            if let viewController = viewController {
+                self.display(from: viewController)
+            }
+        }
 
         let defaultGesture = UITapGestureRecognizer(target: self, action: #selector(tapHandler(_:)))
 

diff --git a/Switchcraft.podspec b/Switchcraft.podspec
@@ -1,6 +1,6 @@
 Pod::Spec.new do |s|
   s.name             = 'Switchcraft'
-  s.version          = '1.3.0'
+  s.version          = '1.3.1'
   s.summary          = 'Drop and go endpoint selector written in Swift.'
   s.homepage         = 'https://github.com/steamclock/Switchcraft'
   s.license          = { :type => 'MIT', :file => 'LICENSE' }