From 7919f79695a3504f498e721c8fd8e2ddae685e50 Mon Sep 17 00:00:00 2001 From: headlessNode Date: Thu, 3 Oct 2024 11:46:13 +0500 Subject: [PATCH 1/9] feat: add C ndarray API and refactor --- .../blas/ext/base/dnanasumors/README.md | 127 +++++++++++++++++- .../benchmark/c/benchmark.length.c | 52 ++++++- .../blas/ext/base/dnanasumors/docs/repl.txt | 17 +-- .../base/dnanasumors/docs/types/index.d.ts | 12 +- .../ext/base/dnanasumors/examples/c/example.c | 7 +- .../stdlib/blas/ext/base/dnanasumors.h | 9 +- .../ext/base/dnanasumors/lib/dnanasumors.js | 37 +---- .../dnanasumors/lib/dnanasumors.native.js | 6 +- .../blas/ext/base/dnanasumors/lib/ndarray.js | 16 +-- .../base/dnanasumors/lib/ndarray.native.js | 15 +-- .../blas/ext/base/dnanasumors/manifest.json | 19 ++- .../blas/ext/base/dnanasumors/src/addon.c | 26 +++- .../dnanasumors/src/{dnanasumors.c => main.c} | 41 +++--- 13 files changed, 277 insertions(+), 107 deletions(-) rename lib/node_modules/@stdlib/blas/ext/base/dnanasumors/src/{dnanasumors.c => main.c} (52%) diff --git a/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/README.md b/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/README.md index a1fc33e940d..4392bdeabd6 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/README.md +++ b/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/README.md @@ -51,7 +51,7 @@ The [_L1_ norm][l1norm] is defined as var dnanasumors = require( '@stdlib/blas/ext/base/dnanasumors' ); ``` -#### dnanasumors( N, x, stride ) +#### dnanasumors( N, x, strideX ) Computes the sum of absolute values ([_L1_ norm][l1norm]) of double-precision floating-point strided array elements, ignoring `NaN` values and using ordinary recursive summation. @@ -69,7 +69,7 @@ The function has the following parameters: - **N**: number of indexed elements. - **x**: input [`Float64Array`][@stdlib/array/float64]. -- **stride**: index increment for `x`. +- **strideX**: index increment for `x`. The `N` and stride parameters determine which elements in the strided array are accessed at runtime. For example, to compute the sum of absolute values ([_L1_ norm][l1norm]) every other element in `x`, @@ -96,7 +96,7 @@ var v = dnanasumors( 4, x1, 2 ); // returns 9.0 ``` -#### dnanasumors.ndarray( N, x, stride, offset ) +#### dnanasumors.ndarray( N, x, strideX, offsetX ) Computes the sum of absolute values ([_L1_ norm][l1norm]) of double-precision floating-point strided array elements, ignoring `NaN` values and using ordinary recursive summation and alternative indexing semantics. @@ -112,9 +112,9 @@ var v = dnanasumors.ndarray( N, x, 1, 0 ); The function has the following additional parameters: -- **offset**: starting index for `x`. +- **offsetX**: starting index for `x`. -While [`typed array`][mdn-typed-array] views mandate a view offset based on the underlying `buffer`, the `offset` parameter supports indexing semantics based on a starting index. For example, to calculate the sum of absolute values ([_L1_ norm][l1norm]) every other value in `x` starting from the second value +While [`typed array`][mdn-typed-array] views mandate a view offset based on the underlying buffer, offset parameter supports indexing semantics based on starting index. For example, to calculate the sum of absolute values ([_L1_ norm][l1norm]) every other value in `x` starting from the second value ```javascript var Float64Array = require( '@stdlib/array/float64' ); @@ -170,6 +170,123 @@ console.log( v ); + + +* * * + +
+ +## C APIs + + + +
+ +
+ + + + + +
+ +### Usage + +```c +#include "stdlib/blas/ext/base/dnanasumors.h" +``` + +#### stdlib_strided_dnanasumors( N, \*X, strideX ) + +Computes the sum of absolute values ([_L1_ norm][l1norm]) of double-precision floating-point strided array elements, ignoring `NaN` values and using ordinary recursive summation. + +```c +const double x[] = { 1.0, 2.0, 0.0/0.0, 4.0 }; + +double v = stdlib_strided_dnanasumors( 4, x, 1 ); +// returns 7.0 +``` + +The function accepts the following arguments: + +- **N**: `[in] CBLAS_INT` number of indexed elements. +- **X**: `[in] double*` input array. +- **strideX**: `[in] CBLAS_INT` index increment for `X`. + +```c +double stdlib_strided_dnanasumors( const CBLAS_INT N, const double *X, const CBLAS_INT strideX ); +``` + +#### stdlib_strided_dnanasumors_ndarray( N, \*X, strideX, offsetX ) + +Computes the sum of absolute values ([_L1_ norm][l1norm]) of double-precision floating-point strided array elements, ignoring `NaN` values and using ordinary recursive summation and alternative indexing semantics. + +```c +const double x[] = { 1.0, 2.0, 0.0/0.0, 4.0 }; + +double v = stdlib_strided_dnanasumors_ndarray( 4, x, 1, 0 ); +// returns 7.0 +``` + +The function accepts the following arguments: + +- **N**: `[in] CBLAS_INT` number of indexed elements. +- **X**: `[in] double*` input array. +- **strideX**: `[in] CBLAS_INT` index increment for `X`. +- **offsetX**: `[in] CBLAS_INT` starting index for `X`. + +```c +double stdlib_strided_dnanasumors_ndarray( const CBLAS_INT N, const double *X, const CBLAS_INT strideX, const CBLAS_INT offsetX ); +``` + +
+ + + + + +
+ +
+ + + + + +
+ +### Examples + +```c +#include "stdlib/blas/ext/base/dnanasumors.h" +#include + +int main( void ) { + // Create a strided array: + const double x[] = { 1.0, 2.0, -3.0, -4.0, 5.0, -6.0, -7.0, 8.0, 0.0/0.0, 0.0/0.0 }; + + // Specify the number of elements: + const int N = 5; + + // Specify the stride length: + const int strideX = 2; + + // Compute the sum: + double v = stdlib_strided_dnanasumors( N, x, strideX ); + + // Print the result: + printf( "sumabs: %lf\n", v ); +} +``` + +
+ + + +
+ + +
diff --git a/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/benchmark/c/benchmark.length.c b/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/benchmark/c/benchmark.length.c index 6d81db4671b..e58841a77f9 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/benchmark/c/benchmark.length.c +++ b/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/benchmark/c/benchmark.length.c @@ -94,7 +94,7 @@ static double rand_double( void ) { * @param len array length * @return elapsed time in seconds */ -static double benchmark( int iterations, int len ) { +static double benchmark1( int iterations, int len ) { double elapsed; double x[ len ]; double v; @@ -124,6 +124,43 @@ static double benchmark( int iterations, int len ) { return elapsed; } +/** +* Runs a benchmark. +* +* @param iterations number of iterations +* @param len array length +* @return elapsed time in seconds +*/ +static double benchmark2( int iterations, int len ) { + double elapsed; + double x[ len ]; + double v; + double t; + int i; + + for ( i = 0; i < len; i++ ) { + if ( rand_double() < 0.2 ) { + x[ i ] = 0.0 / 0.0; // NaN + } else { + x[ i ] = ( rand_double() * 20000.0 ) - 10000.0; + } + } + v = 0.0; + t = tic(); + for ( i = 0; i < iterations; i++ ) { + v = stdlib_strided_dnanasumors_ndarray( len, x, 1, 0 ); + if ( v != v ) { + printf( "should not return NaN\n" ); + break; + } + } + elapsed = tic() - t; + if ( v != v ) { + printf( "should not return NaN\n" ); + } + return elapsed; +} + /** * Main execution sequence. */ @@ -146,7 +183,18 @@ int main( void ) { for ( j = 0; j < REPEATS; j++ ) { count += 1; printf( "# c::%s:len=%d\n", NAME, len ); - elapsed = benchmark( iter, len ); + elapsed = benchmark1( iter, len ); + print_results( iter, elapsed ); + printf( "ok %d benchmark finished\n", count ); + } + } + for ( i = MIN; i <= MAX; i++ ) { + len = pow( 10, i ); + iter = ITERATIONS / pow( 10, i-1 ); + for ( j = 0; j < REPEATS; j++ ) { + count += 1; + printf( "# c::%s:ndarray:len=%d\n", NAME, len ); + elapsed = benchmark2( iter, len ); print_results( iter, elapsed ); printf( "ok %d benchmark finished\n", count ); } diff --git a/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/docs/repl.txt b/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/docs/repl.txt index 4939008c7a5..4ea78178d5a 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/docs/repl.txt +++ b/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/docs/repl.txt @@ -1,10 +1,10 @@ -{{alias}}( N, x, stride ) +{{alias}}( N, x, strideX ) Computes the sum of absolute values (L1 norm) of double-precision floating- point strided array elements, ignoring `NaN` values and using ordinary recursive summation. - The `N` and `stride` parameters determine which elements in `x` are accessed + The `N` and stride parameters determine which elements in `x` are accessed at runtime. Indexing is relative to the first index. To introduce an offset, use a typed @@ -20,7 +20,7 @@ x: Float64Array Input array. - stride: integer + strideX: integer Index increment. Returns @@ -50,14 +50,15 @@ > {{alias}}( N, x1, stride ) 5.0 -{{alias}}.ndarray( N, x, stride, offset ) + +{{alias}}.ndarray( N, x, strideX, offsetX ) Computes the sum of absolute values (L1 norm) of double-precision floating- point strided array elements, ignoring `NaN` values and using ordinary recursive summation alternative indexing semantics. While typed array views mandate a view offset based on the underlying - buffer, the `offset` parameter supports indexing semantics based on a - starting index. + buffer, offset parameter support indexing semantics based on starting + index. Parameters ---------- @@ -67,10 +68,10 @@ x: Float64Array Input array. - stride: integer + strideX: integer Index increment. - offset: integer + offsetX: integer Starting index. Returns diff --git a/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/docs/types/index.d.ts b/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/docs/types/index.d.ts index 15a413b8f9c..a8aa70f8d6b 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/docs/types/index.d.ts +++ b/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/docs/types/index.d.ts @@ -27,7 +27,7 @@ interface Routine { * * @param N - number of indexed elements * @param x - input array - * @param stride - stride length + * @param strideX - stride length * @returns sum * * @example @@ -38,15 +38,15 @@ interface Routine { * var v = dnanasumors( x.length, x, 1 ); * // returns 5.0 */ - ( N: number, x: Float64Array, stride: number ): number; + ( N: number, x: Float64Array, strideX: number ): number; /** * Computes the sum of absolute values (L1 norm) of double-precision floating-point strided array elements, ignoring `NaN` values and using ordinary recursive summation and alternative indexing semantics. * * @param N - number of indexed elements * @param x - input array - * @param stride - stride length - * @param offset - starting index + * @param strideX - stride length + * @param offsetX - starting index * @returns sum * * @example @@ -57,7 +57,7 @@ interface Routine { * var v = dnanasumors.ndarray( x.length, x, 1, 0 ); * // returns 5.0 */ - ndarray( N: number, x: Float64Array, stride: number, offset: number ): number; + ndarray( N: number, x: Float64Array, strideX: number, offsetX: number ): number; } /** @@ -65,7 +65,7 @@ interface Routine { * * @param N - number of indexed elements * @param x - input array -* @param stride - stride length +* @param strideX - stride length * @returns sum * * @example diff --git a/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/examples/c/example.c b/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/examples/c/example.c index 638a9c9fe60..9e9d3f1c6f5 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/examples/c/example.c +++ b/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/examples/c/example.c @@ -17,7 +17,6 @@ */ #include "stdlib/blas/ext/base/dnanasumors.h" -#include #include int main( void ) { @@ -25,13 +24,13 @@ int main( void ) { const double x[] = { 1.0, 2.0, -3.0, -4.0, 5.0, -6.0, -7.0, 8.0, 0.0/0.0, 0.0/0.0 }; // Specify the number of elements: - const int64_t N = 5; + const int N = 5; // Specify the stride length: - const int64_t stride = 2; + const int strideX = 2; // Compute the sum: - double v = stdlib_strided_dnanasumors( N, x, stride ); + double v = stdlib_strided_dnanasumors( N, x, strideX ); // Print the result: printf( "sumabs: %lf\n", v ); diff --git a/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/include/stdlib/blas/ext/base/dnanasumors.h b/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/include/stdlib/blas/ext/base/dnanasumors.h index 944bc5b49ba..17f9141b716 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/include/stdlib/blas/ext/base/dnanasumors.h +++ b/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/include/stdlib/blas/ext/base/dnanasumors.h @@ -19,7 +19,7 @@ #ifndef STDLIB_BLAS_EXT_BASE_DNANASUMORS_H #define STDLIB_BLAS_EXT_BASE_DNANASUMORS_H -#include +#include "stdlib/blas/base/shared.h" /* * If C++, prevent name mangling so that the compiler emits a binary file having undecorated names, thus mirroring the behavior of a C compiler. @@ -31,7 +31,12 @@ extern "C" { /** * Computes the sum of absolute values (L1 norm) of double-precision floating-point strided array elements, ignoring `NaN` values and using ordinary recursive summation. */ -double stdlib_strided_dnanasumors( const int64_t N, const double *X, const int64_t stride ); +double API_SUFFIX(stdlib_strided_dnanasumors)( const CBLAS_INT N, const double *X, const CBLAS_INT strideX ); + +/** +* Computes the sum of absolute values (L1 norm) of double-precision floating-point strided array elements, ignoring `NaN` values and using ordinary recursive summation and alternative indexing semantics. +*/ +double API_SUFFIX(stdlib_strided_dnanasumors_ndarray)( const CBLAS_INT N, const double *X, const CBLAS_INT strideX, const CBLAS_INT offsetX ); #ifdef __cplusplus } diff --git a/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/lib/dnanasumors.js b/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/lib/dnanasumors.js index bb0ac074048..3dac0f10b21 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/lib/dnanasumors.js +++ b/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/lib/dnanasumors.js @@ -20,8 +20,8 @@ // MODULES // -var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); +var stride2offset = require( '@stdlib/strided/base/stride2offset' ); +var ndarray = require( './ndarray.js' ); // MAIN // @@ -31,7 +31,7 @@ var abs = require( '@stdlib/math/base/special/abs' ); * * @param {PositiveInteger} N - number of indexed elements * @param {Float64Array} x - input array -* @param {integer} stride - stride length +* @param {integer} strideX - stride length * @returns {number} sum * * @example @@ -43,35 +43,8 @@ var abs = require( '@stdlib/math/base/special/abs' ); * var v = dnanasumors( N, x, 1 ); * // returns 5.0 */ -function dnanasumors( N, x, stride ) { - var sum; - var ix; - var v; - var i; - - if ( N <= 0 ) { - return 0.0; - } - if ( N === 1 || stride === 0 ) { - if ( isnan( x[ 0 ] ) ) { - return 0.0; - } - return abs( x[ 0 ] ); - } - if ( stride < 0 ) { - ix = (1-N) * stride; - } else { - ix = 0; - } - sum = 0.0; - for ( i = 0; i < N; i++ ) { - v = x[ ix ]; - if ( isnan( v ) === false ) { - sum += abs( v ); - } - ix += stride; - } - return sum; +function dnanasumors( N, x, strideX ) { + return ndarray( N, x, strideX, stride2offset( N, strideX ) ); } diff --git a/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/lib/dnanasumors.native.js b/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/lib/dnanasumors.native.js index 19fec9db514..f796b2adbe2 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/lib/dnanasumors.native.js +++ b/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/lib/dnanasumors.native.js @@ -30,7 +30,7 @@ var addon = require( './../src/addon.node' ); * * @param {PositiveInteger} N - number of indexed elements * @param {Float64Array} x - input array -* @param {integer} stride - stride length +* @param {integer} strideX - stride length * @returns {number} sum * * @example @@ -42,8 +42,8 @@ var addon = require( './../src/addon.node' ); * var v = dnanasumors( N, x, 1 ); * // returns 5.0 */ -function dnanasumors( N, x, stride ) { - return addon( N, x, stride ); +function dnanasumors( N, x, strideX ) { + return addon( N, x, strideX ); } diff --git a/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/lib/ndarray.js b/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/lib/ndarray.js index f7646c21a7c..c4fd5744038 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/lib/ndarray.js +++ b/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/lib/ndarray.js @@ -31,8 +31,8 @@ var abs = require( '@stdlib/math/base/special/abs' ); * * @param {PositiveInteger} N - number of indexed elements * @param {Float64Array} x - input array -* @param {integer} stride - stride length -* @param {NonNegativeInteger} offset - starting index +* @param {integer} strideX - index increment +* @param {NonNegativeInteger} offsetX - starting index * @returns {number} sum * * @example @@ -43,7 +43,7 @@ var abs = require( '@stdlib/math/base/special/abs' ); * var v = dnanasumors( 4, x, 2, 1 ); * // returns 9.0 */ -function dnanasumors( N, x, stride, offset ) { +function dnanasumors( N, x, strideX, offsetX ) { var sum; var ix; var v; @@ -52,20 +52,20 @@ function dnanasumors( N, x, stride, offset ) { if ( N <= 0 ) { return 0.0; } - if ( N === 1 || stride === 0 ) { - if ( isnan( x[ offset ] ) ) { + if ( N === 1 || strideX === 0 ) { + if ( isnan( x[ offsetX ] ) ) { return 0.0; } - return abs( x[ offset ] ); + return abs( x[ offsetX ] ); } - ix = offset; + ix = offsetX; sum = 0.0; for ( i = 0; i < N; i++ ) { v = x[ ix ]; if ( isnan( v ) === false ) { sum += abs( v ); } - ix += stride; + ix += strideX; } return sum; } diff --git a/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/lib/ndarray.native.js b/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/lib/ndarray.native.js index f39d4e51127..7d2c1d82c8e 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/lib/ndarray.native.js +++ b/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/lib/ndarray.native.js @@ -20,9 +20,7 @@ // MODULES // -var minViewBufferIndex = require( '@stdlib/strided/base/min-view-buffer-index' ); -var offsetView = require( '@stdlib/strided/base/offset-view' ); -var addon = require( './dnanasumors.native.js' ); +var addon = require( './../src/addon.node' ); // MAIN // @@ -32,8 +30,8 @@ var addon = require( './dnanasumors.native.js' ); * * @param {PositiveInteger} N - number of indexed elements * @param {Float64Array} x - input array -* @param {integer} stride - stride length -* @param {NonNegativeInteger} offset - starting index +* @param {integer} strideX - index increment +* @param {NonNegativeInteger} offsetX - starting index * @returns {number} sum * * @example @@ -44,11 +42,8 @@ var addon = require( './dnanasumors.native.js' ); * var v = dnanasumors( 4, x, 2, 1 ); * // returns 9.0 */ -function dnanasumors( N, x, stride, offset ) { - var view; - offset = minViewBufferIndex( N, stride, offset ); - view = offsetView( x, offset ); - return addon( N, view, stride ); +function dnanasumors( N, x, strideX, offsetX ) { + return addon.ndarray( N, x, strideX, offsetX ); } diff --git a/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/manifest.json b/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/manifest.json index 67b670274de..a944a1c63d6 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/manifest.json +++ b/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/manifest.json @@ -28,7 +28,7 @@ { "task": "build", "src": [ - "./src/dnanasumors.c" + "./src/main.c" ], "include": [ "./include" @@ -41,13 +41,16 @@ "@stdlib/napi/argv-int64", "@stdlib/napi/argv-strided-float64array", "@stdlib/math/base/assert/is-nan", - "@stdlib/math/base/special/abs" + "@stdlib/math/base/special/abs", + "@stdlib/blas/base/shared", + "@stdlib/strided/base/stride2offset", + "@stdlib/napi/create-double" ] }, { "task": "benchmark", "src": [ - "./src/dnanasumors.c" + "./src/main.c" ], "include": [ "./include" @@ -56,13 +59,15 @@ "libpath": [], "dependencies": [ "@stdlib/math/base/assert/is-nan", - "@stdlib/math/base/special/abs" + "@stdlib/math/base/special/abs", + "@stdlib/blas/base/shared", + "@stdlib/strided/base/stride2offset" ] }, { "task": "examples", "src": [ - "./src/dnanasumors.c" + "./src/main.c" ], "include": [ "./include" @@ -71,7 +76,9 @@ "libpath": [], "dependencies": [ "@stdlib/math/base/assert/is-nan", - "@stdlib/math/base/special/abs" + "@stdlib/math/base/special/abs", + "@stdlib/blas/base/shared", + "@stdlib/strided/base/stride2offset" ] } ] diff --git a/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/src/addon.c b/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/src/addon.c index dac318b22d9..1ee555d3ace 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/src/addon.c +++ b/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/src/addon.c @@ -17,12 +17,13 @@ */ #include "stdlib/blas/ext/base/dnanasumors.h" +#include "stdlib/blas/base/shared.h" #include "stdlib/napi/export.h" #include "stdlib/napi/argv.h" #include "stdlib/napi/argv_int64.h" #include "stdlib/napi/argv_strided_float64array.h" +#include "stdlib/napi/create_double.h" #include -#include /** * Receives JavaScript callback invocation data. @@ -36,12 +37,25 @@ static napi_value addon( napi_env env, napi_callback_info info ) { STDLIB_NAPI_ARGV_INT64( env, N, argv, 0 ); STDLIB_NAPI_ARGV_INT64( env, strideX, argv, 2 ); STDLIB_NAPI_ARGV_STRIDED_FLOAT64ARRAY( env, X, N, strideX, argv, 1 ); + STDLIB_NAPI_CREATE_DOUBLE( env, API_SUFFIX(stdlib_strided_dnanasumors)( N, X, strideX ), v ); + return v; +} - napi_value v; - napi_status status = napi_create_double( env, stdlib_strided_dnanasumors( N, X, strideX ), &v ); - assert( status == napi_ok ); - +/** +* Receives JavaScript callback invocation data. +* +* @param env environment under which the function is invoked +* @param info callback data +* @return Node-API value +*/ +static napi_value addon_method( napi_env env, napi_callback_info info ) { + STDLIB_NAPI_ARGV( env, info, argv, argc, 4 ); + STDLIB_NAPI_ARGV_INT64( env, N, argv, 0 ); + STDLIB_NAPI_ARGV_INT64( env, strideX, argv, 2 ); + STDLIB_NAPI_ARGV_INT64( env, offsetX, argv, 3 ); + STDLIB_NAPI_ARGV_STRIDED_FLOAT64ARRAY( env, X, N, strideX, argv, 1 ); + STDLIB_NAPI_CREATE_DOUBLE( env, API_SUFFIX(stdlib_strided_dnanasumors_ndarray)( N, X, strideX, offsetX ), v ); return v; } -STDLIB_NAPI_MODULE_EXPORT_FCN( addon ) \ No newline at end of file +STDLIB_NAPI_MODULE_EXPORT_FCN_WITH_METHOD( addon, "ndarray", addon_method ) diff --git a/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/src/dnanasumors.c b/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/src/main.c similarity index 52% rename from lib/node_modules/@stdlib/blas/ext/base/dnanasumors/src/dnanasumors.c rename to lib/node_modules/@stdlib/blas/ext/base/dnanasumors/src/main.c index 5e731dd35e6..cfe2b6ae24e 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/src/dnanasumors.c +++ b/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/src/main.c @@ -17,45 +17,56 @@ */ #include "stdlib/blas/ext/base/dnanasumors.h" +#include "stdlib/strided/base/stride2offset.h" #include "stdlib/math/base/assert/is_nan.h" #include "stdlib/math/base/special/abs.h" -#include +#include "stdlib/blas/base/shared.h" /** * Computes the sum of absolute values (L1 norm) of double-precision floating-point strided array elements, ignoring `NaN` values and using ordinary recursive summation. * -* @param N number of indexed elements -* @param X input array -* @param stride stride length -* @return output value +* @param N number of indexed elements +* @param X input array +* @param strideX stride length +* @return output value */ -double stdlib_strided_dnanasumors( const int64_t N, const double *X, const int64_t stride ) { +double API_SUFFIX(stdlib_strided_dnanasumors)( const CBLAS_INT N, const double *X, const CBLAS_INT strideX ) { + CBLAS_INT ox = stdlib_strided_stride2offset( N, strideX ); + return API_SUFFIX(stdlib_strided_dnanasumors_ndarray)( N, X, strideX, ox ); +} + +/** +* Computes the sum of absolute values (L1 norm) of double-precision floating-point strided array elements, ignoring `NaN` values and using ordinary recursive summation and alternative indexing semantics. +* +* @param N number of indexed elements +* @param X input array +* @param strideX index increment +* @param offsetX starting index +* @return output value +*/ +double API_SUFFIX(stdlib_strided_dnanasumors_ndarray)( const CBLAS_INT N, const double *X, const CBLAS_INT strideX, const CBLAS_INT offsetX ) { double sum; - int64_t ix; - int64_t i; + CBLAS_INT ix; + CBLAS_INT i; double v; if ( N <= 0 ) { return 0.0; } - if ( N == 1 || stride == 0 ) { + if ( N == 1 || strideX == 0 ) { if ( stdlib_base_is_nan( X[ 0 ] ) ) { return 0.0; } return stdlib_base_abs( X[ 0 ] ); } - if ( stride < 0 ) { - ix = (1-N) * stride; - } else { - ix = 0; - } + ix = offsetX; sum = 0.0; for ( i = 0; i < N; i++ ) { v = X[ ix ]; if ( !stdlib_base_is_nan( v ) ) { sum += stdlib_base_abs( v ); } - ix += stride; + ix += strideX; } return sum; } From 279f31ccb90f81897409cd1d8e1a30052dfca042 Mon Sep 17 00:00:00 2001 From: Athan Date: Thu, 3 Oct 2024 00:42:14 -0700 Subject: [PATCH 2/9] Apply suggestions from code review Signed-off-by: Athan --- lib/node_modules/@stdlib/blas/ext/base/dnanasumors/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/README.md b/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/README.md index 4392bdeabd6..2bec6c70cde 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/README.md +++ b/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/README.md @@ -114,7 +114,7 @@ The function has the following additional parameters: - **offsetX**: starting index for `x`. -While [`typed array`][mdn-typed-array] views mandate a view offset based on the underlying buffer, offset parameter supports indexing semantics based on starting index. For example, to calculate the sum of absolute values ([_L1_ norm][l1norm]) every other value in `x` starting from the second value +While [`typed array`][mdn-typed-array] views mandate a view offset based on the underlying buffer, the offset parameter supports indexing semantics based on a starting index. For example, to calculate the sum of absolute values ([_L1_ norm][l1norm]) for every other value in `x` starting from the second value ```javascript var Float64Array = require( '@stdlib/array/float64' ); From 9dede03b7c1f2ccdbe40a3e891563f584fdf2d25 Mon Sep 17 00:00:00 2001 From: Athan Date: Thu, 3 Oct 2024 00:42:48 -0700 Subject: [PATCH 3/9] Apply suggestions from code review Signed-off-by: Athan --- lib/node_modules/@stdlib/blas/ext/base/dnanasumors/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/README.md b/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/README.md index 2bec6c70cde..522eb711cad 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/README.md +++ b/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/README.md @@ -71,7 +71,7 @@ The function has the following parameters: - **x**: input [`Float64Array`][@stdlib/array/float64]. - **strideX**: index increment for `x`. -The `N` and stride parameters determine which elements in the strided array are accessed at runtime. For example, to compute the sum of absolute values ([_L1_ norm][l1norm]) every other element in `x`, +The `N` and stride parameters determine which elements in the strided array are accessed at runtime. For example, to compute the sum of absolute values ([_L1_ norm][l1norm]) for every other element in `x`, ```javascript var Float64Array = require( '@stdlib/array/float64' ); From 16e5e48d621cc5de8314006ec1aba39e975dd94d Mon Sep 17 00:00:00 2001 From: Athan Date: Thu, 3 Oct 2024 00:43:35 -0700 Subject: [PATCH 4/9] Apply suggestions from code review Signed-off-by: Athan --- .../blas/ext/base/dnanasumors/benchmark/c/benchmark.length.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/benchmark/c/benchmark.length.c b/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/benchmark/c/benchmark.length.c index e58841a77f9..aaaebb77dd7 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/benchmark/c/benchmark.length.c +++ b/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/benchmark/c/benchmark.length.c @@ -188,7 +188,7 @@ int main( void ) { printf( "ok %d benchmark finished\n", count ); } } - for ( i = MIN; i <= MAX; i++ ) { + for ( i = MIN; i <= MAX; i++ ) { len = pow( 10, i ); iter = ITERATIONS / pow( 10, i-1 ); for ( j = 0; j < REPEATS; j++ ) { From de4db91dbf8b0960791416db1af9a6de25d3bed7 Mon Sep 17 00:00:00 2001 From: Athan Date: Thu, 3 Oct 2024 00:44:42 -0700 Subject: [PATCH 5/9] Apply suggestions from code review Signed-off-by: Athan --- .../@stdlib/blas/ext/base/dnanasumors/docs/repl.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/docs/repl.txt b/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/docs/repl.txt index 4ea78178d5a..676d8103545 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/docs/repl.txt +++ b/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/docs/repl.txt @@ -57,7 +57,7 @@ recursive summation alternative indexing semantics. While typed array views mandate a view offset based on the underlying - buffer, offset parameter support indexing semantics based on starting + buffer, the offset parameter supports indexing semantics based on a starting index. Parameters From 39e4cb976e4874730ab73dc7a2e35aa5410881b9 Mon Sep 17 00:00:00 2001 From: headlessNode Date: Thu, 3 Oct 2024 17:16:12 +0500 Subject: [PATCH 6/9] fix: apply code review suggestion --- .../@stdlib/blas/ext/base/dnanasumors/lib/ndarray.js | 4 ++-- .../@stdlib/blas/ext/base/dnanasumors/src/main.c | 6 +++--- .../blas/ext/base/dnanasumors/test/test.dnanasumors.js | 4 ++-- .../ext/base/dnanasumors/test/test.dnanasumors.native.js | 4 ++-- .../@stdlib/blas/ext/base/dnanasumors/test/test.ndarray.js | 4 ++-- .../blas/ext/base/dnanasumors/test/test.ndarray.native.js | 4 ++-- 6 files changed, 13 insertions(+), 13 deletions(-) diff --git a/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/lib/ndarray.js b/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/lib/ndarray.js index c4fd5744038..3a9a591a4a0 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/lib/ndarray.js +++ b/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/lib/ndarray.js @@ -52,11 +52,11 @@ function dnanasumors( N, x, strideX, offsetX ) { if ( N <= 0 ) { return 0.0; } - if ( N === 1 || strideX === 0 ) { + if ( strideX === 0 ) { if ( isnan( x[ offsetX ] ) ) { return 0.0; } - return abs( x[ offsetX ] ); + return abs( x[ offsetX ] * N ); } ix = offsetX; sum = 0.0; diff --git a/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/src/main.c b/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/src/main.c index cfe2b6ae24e..9d048dec8e2 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/src/main.c +++ b/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/src/main.c @@ -53,11 +53,11 @@ double API_SUFFIX(stdlib_strided_dnanasumors_ndarray)( const CBLAS_INT N, const if ( N <= 0 ) { return 0.0; } - if ( N == 1 || strideX == 0 ) { - if ( stdlib_base_is_nan( X[ 0 ] ) ) { + if ( strideX == 0 ) { + if ( stdlib_base_is_nan( X[ offsetX ] ) ) { return 0.0; } - return stdlib_base_abs( X[ 0 ] ); + return stdlib_base_abs( X[ offsetX ] * N ); } ix = offsetX; sum = 0.0; diff --git a/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/test/test.dnanasumors.js b/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/test/test.dnanasumors.js index f97f48efdaa..6304df65fd9 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/test/test.dnanasumors.js +++ b/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/test/test.dnanasumors.js @@ -148,14 +148,14 @@ tape( 'the function supports a negative `stride` parameter', function test( t ) t.end(); }); -tape( 'if provided a `stride` parameter equal to `0`, the function returns the first element', function test( t ) { +tape( 'if provided a `stride` parameter equal to `0`, the function returns the sum of the first element repeated N times', function test( t ) { var x; var v; x = new Float64Array( [ 1.0, -2.0, -4.0, 5.0, 3.0 ] ); v = dnanasumors( x.length, x, 0 ); - t.strictEqual( v, 1.0, 'returns expected value' ); + t.strictEqual( v, 5.0, 'returns expected value' ); t.end(); }); diff --git a/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/test/test.dnanasumors.native.js b/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/test/test.dnanasumors.native.js index 68daea1d23b..0e347bd4025 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/test/test.dnanasumors.native.js +++ b/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/test/test.dnanasumors.native.js @@ -241,14 +241,14 @@ tape( 'the function supports a negative `stride` parameter', opts, function test t.end(); }); -tape( 'if provided a `stride` parameter equal to `0`, the function returns the first element', opts, function test( t ) { +tape( 'if provided a `stride` parameter equal to `0`, the function returns the sum of the first element repeated N times', function test( t ) { var x; var v; x = new Float64Array( [ 1.0, -2.0, -4.0, 5.0, 3.0 ] ); v = dnanasumors( x.length, x, 0 ); - t.strictEqual( v, 1.0, 'returns expected value' ); + t.strictEqual( v, 5.0, 'returns expected value' ); t.end(); }); diff --git a/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/test/test.ndarray.js b/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/test/test.ndarray.js index 3858f0ab956..86f7f08f0c7 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/test/test.ndarray.js +++ b/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/test/test.ndarray.js @@ -150,14 +150,14 @@ tape( 'the function supports a negative `stride` parameter', function test( t ) t.end(); }); -tape( 'if provided a `stride` parameter equal to `0`, the function returns the first indexed element', function test( t ) { +tape( 'if provided a `stride` parameter equal to `0`, the function returns the sum of the first element repeated N times', function test( t ) { var x; var v; x = new Float64Array( [ 1.0, -2.0, -4.0, 5.0, 3.0 ] ); v = dnanasumors( x.length, x, 0, 0 ); - t.strictEqual( v, 1.0, 'returns expected value' ); + t.strictEqual( v, 5.0, 'returns expected value' ); t.end(); }); diff --git a/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/test/test.ndarray.native.js b/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/test/test.ndarray.native.js index b50ff22d808..839ce299444 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/test/test.ndarray.native.js +++ b/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/test/test.ndarray.native.js @@ -159,14 +159,14 @@ tape( 'the function supports a negative `stride` parameter', opts, function test t.end(); }); -tape( 'if provided a `stride` parameter equal to `0`, the function returns the first indexed element', opts, function test( t ) { +tape( 'if provided a `stride` parameter equal to `0`, the function returns the sum of the first element repeated N times', function test( t ) { var x; var v; x = new Float64Array( [ 1.0, -2.0, -4.0, 5.0, 3.0 ] ); v = dnanasumors( x.length, x, 0, 0 ); - t.strictEqual( v, 1.0, 'returns expected value' ); + t.strictEqual( v, 5.0, 'returns expected value' ); t.end(); }); From 335a3f8fb57397f7c614bac6b3d31943d4053539 Mon Sep 17 00:00:00 2001 From: Athan Date: Thu, 3 Oct 2024 15:07:01 -0700 Subject: [PATCH 7/9] Apply suggestions from code review Signed-off-by: Athan --- .../@stdlib/blas/ext/base/dnanasumors/lib/ndarray.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/lib/ndarray.js b/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/lib/ndarray.js index 3a9a591a4a0..2143c9cb38f 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/lib/ndarray.js +++ b/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/lib/ndarray.js @@ -56,7 +56,7 @@ function dnanasumors( N, x, strideX, offsetX ) { if ( isnan( x[ offsetX ] ) ) { return 0.0; } - return abs( x[ offsetX ] * N ); + return abs( x[ offsetX ] ) * N; } ix = offsetX; sum = 0.0; From c924682a92ed8b356c57076d75ea8861b2b06d48 Mon Sep 17 00:00:00 2001 From: Athan Date: Thu, 3 Oct 2024 15:07:53 -0700 Subject: [PATCH 8/9] Apply suggestions from code review Signed-off-by: Athan --- lib/node_modules/@stdlib/blas/ext/base/dnanasumors/src/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/src/main.c b/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/src/main.c index 9d048dec8e2..18fa271cfd4 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/src/main.c +++ b/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/src/main.c @@ -57,7 +57,7 @@ double API_SUFFIX(stdlib_strided_dnanasumors_ndarray)( const CBLAS_INT N, const if ( stdlib_base_is_nan( X[ offsetX ] ) ) { return 0.0; } - return stdlib_base_abs( X[ offsetX ] * N ); + return stdlib_base_abs( X[ offsetX ] ) * N; } ix = offsetX; sum = 0.0; From ef4da57c86ecd252d6132b52e18edd47f5fd0f14 Mon Sep 17 00:00:00 2001 From: Athan Date: Thu, 3 Oct 2024 15:11:18 -0700 Subject: [PATCH 9/9] Apply suggestions from code review Signed-off-by: Athan --- .../blas/ext/base/dnanasumors/test/test.dnanasumors.native.js | 2 +- .../blas/ext/base/dnanasumors/test/test.ndarray.native.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/test/test.dnanasumors.native.js b/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/test/test.dnanasumors.native.js index 0e347bd4025..cc15c992eb6 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/test/test.dnanasumors.native.js +++ b/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/test/test.dnanasumors.native.js @@ -241,7 +241,7 @@ tape( 'the function supports a negative `stride` parameter', opts, function test t.end(); }); -tape( 'if provided a `stride` parameter equal to `0`, the function returns the sum of the first element repeated N times', function test( t ) { +tape( 'if provided a `stride` parameter equal to `0`, the function returns the sum of the first element repeated N times', opts, function test( t ) { var x; var v; diff --git a/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/test/test.ndarray.native.js b/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/test/test.ndarray.native.js index 839ce299444..0c622dbbdee 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/test/test.ndarray.native.js +++ b/lib/node_modules/@stdlib/blas/ext/base/dnanasumors/test/test.ndarray.native.js @@ -159,7 +159,7 @@ tape( 'the function supports a negative `stride` parameter', opts, function test t.end(); }); -tape( 'if provided a `stride` parameter equal to `0`, the function returns the sum of the first element repeated N times', function test( t ) { +tape( 'if provided a `stride` parameter equal to `0`, the function returns the sum of the first element repeated N times', opts, function test( t ) { var x; var v;