fix: handle seed initialization correctly #3005
Closed
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation used a direct property check (`config.seed`), which could inadvertently treat falsy values like "0" as missing. This caused incorrect random seed initialization in some cases. Changed the condition to explicitly check for the presence of the `seed` property using `Object.prototype.hasOwnProperty.call()`. Now, seed initialization handles falsy but valid seed values correctly.
stdlib-bot
reviewed
Oct 13, 2024
There was a problem hiding this comment.
@rishav2404 Thanks for this PR! The bug fix is alright, but could you please use
var hasOwnProp = require( '@stdlib/assert/has-own-property' ); instead of the prototype method here?
|
@Planeshifter thanks for your guide. I am pushing it in a while. |
1 task
|
This PR is superseded by #3007. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation used a direct property check (
config.seed), which could inadvertently treat falsy values like "0" as missing. This caused incorrect random seed initialization in some cases.Changed the condition to explicitly check for the presence of the
seedproperty usingObject.prototype.hasOwnProperty.call(). Now, seed initialization handles falsy but valid seed values correctly.Resolves #2952.
Description
This pull request:
non-deterministic behavior.
Related Issues
No.
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers