Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify and refactor Send screen #21468

Open
Tracked by #21434
vkjr opened this issue Oct 20, 2024 · 0 comments · May be fixed by #21507
Open
Tracked by #21434

Simplify and refactor Send screen #21468

vkjr opened this issue Oct 20, 2024 · 0 comments · May be fixed by #21507
Assignees
Labels
tech-debt wallet-core Issues for mobile wallet team
Milestone

Comments

@vkjr
Copy link
Contributor

vkjr commented Oct 20, 2024

Problem

The logic of Send screen is extremely complicated to understand and to change.
It mixes all kinds of logic and contains many calculations. Only the top-leve 'let' contains 160 lines.
In order to work effectively with this critical part of code it need to be refactored and simplified

Implementation

Suggested implementation is to move all the calculations inside view to subscriptions. That subscriptions can be used in sub-views.
Brunch with suggested implementation

Acceptance Criteria

Send logic is easy to understand.
No regressions.

Notes

Future Steps

@vkjr vkjr added tech-debt wallet-core Issues for mobile wallet team labels Oct 20, 2024
@vkjr vkjr self-assigned this Oct 20, 2024
@vkjr vkjr moved this to In Progress in Status Desktop/Mobile Board Oct 20, 2024
@vkjr vkjr added this to the 2.32.0 Beta milestone Oct 28, 2024
@vkjr vkjr moved this from In Progress to Code Review in Status Desktop/Mobile Board Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech-debt wallet-core Issues for mobile wallet team
Projects
Status: Code Review
Development

Successfully merging a pull request may close this issue.

1 participant