Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometimes sender's contact request remains in pending state despite receiver has accepted it #21371

Closed
pavloburykh opened this issue Oct 3, 2024 · 3 comments
Labels
mobile-core re-check waku All issues relating to the Status Waku integration.
Milestone

Comments

@pavloburykh
Copy link
Contributor

Bug is not reproducible every time. Might be Waku issue.

Steps:

  1. User A sends contact request to User B
  2. User B receives and accepts contact request
  3. See if request status is changed from Pending to Accepted for User A and User B appears as his contact

Actual result: Request remains in Pending state. User B does not appear as contact for User A despite request has been accepted.

User_A_request_sender.zip
User_B_request_receiver.zip

photo_2024-10-03 11 09 22

  • Status version: nightly
  • Operating System: Android, iOS
@pavloburykh pavloburykh added this to the 2.31.0 Beta milestone Oct 3, 2024
@pavloburykh pavloburykh added the waku All issues relating to the Status Waku integration. label Oct 3, 2024
@chaitanyaprem
Copy link
Contributor

this has been noticed multiple times recently in various tests. i think the source of the issue is something else because for some reason only the mobile instance is only connected to store nodes and not any bootstrap nodes (which then causes further issues because since there are peers available the node thinks it is online but peerexchange, lightpush and filter protocols won't work since there are no peers supporting those protocols)
similar issue noticed here status-im/status-go#5679 where there is DNS failure. this leads to only store nodes being connected which doesn't have peer-exchange enabled hence leading to failure of filter,lightpush and peerexchange client side protocols leading to reliability issues.

the logs that we are observing are side-effect of the issue which is somewhere i am suspecting is somewhere else in status-go code. Probable suspect is how the bootstrap nodes are set or something in the waku initialization sequence of status-go is failing and causing no other peers to be connected.

#21386 is the mobile PR that reduces log flooding and might provide some useful logs to help root-cause the issue i.e why node is able to connect to store nodes but no other bootstrap nodes.

@pavloburykh
Copy link
Contributor Author

#21386 is the mobile PR that reduces log flooding and might provide some useful logs to help root-cause the issue i.e why node is able to connect to store nodes but no other bootstrap nodes.

Thank you @chaitanyaprem! I have triggered e2e in this PR and faced the issue. I have attached logs in this comment, please take a look #21386 (comment)

@churik
Copy link
Member

churik commented Oct 17, 2024

allegedly fixed in status-im/status-go#5785

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile-core re-check waku All issues relating to the Status Waku integration.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants