nimbus-verified-proxy integration #3281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Checklist
|
Jenkins BuildsClick to see older builds (53)
|
This was referenced Mar 14, 2023
vitvly
force-pushed
the
lc-proxy
branch
3 times, most recently
from
9436d56
to
1ace3ad
Compare
vitvly
force-pushed
the
lc-proxy
branch
2 times, most recently
from
f5d1821
to
40a6268
Compare
cammellos
reviewed
May 17, 2023
rpc/verif_proxy.go
Outdated
| c.RegisterHandler( | ||
| params.BalanceMethodName, | ||
| func(ctx context.Context, v uint64, params ...interface{}) (interface{}, error) { | ||
| fmt.Println("### inside registered handler") |
cammellos
reviewed
May 17, 2023
rpc/verif_proxy.go
Outdated
|
|
||
| func NewVerifProxy(cfg *proxy.Config) *VerifProxy { | ||
| endpoint := "http://" + cfg.RpcAddress + ":" + fmt.Sprint(cfg.RpcPort) | ||
| fmt.Println("### NewVerifProxy: ", endpoint) |
cammellos
reviewed
May 17, 2023
rpc/verif_proxy.go
Outdated
| var result hexutil.Big | ||
| err := p.client.CallContext(ctx, &result, "eth_getBalance", address, "latest") | ||
| if err != nil { | ||
| fmt.Println("### IN GetBalance, error ", err) |
cammellos
approved these changes
May 17, 2023
vitvly
force-pushed
the
lc-proxy
branch
3 times, most recently
from
3d45661
to
81c868b
Compare
|
Thanks @cammellos
|
Samyoul
reviewed
May 24, 2023
| "github.com/ethereum/go-ethereum/common/hexutil" | ||
| "github.com/ethereum/go-ethereum/log" | ||
| gethrpc "github.com/ethereum/go-ethereum/rpc" | ||
| proxy "github.com/siphiuel/lc-proxy-wrapper" |
There was a problem hiding this comment.
There is a chance that this line will give a lint error as your own repos would be considered 3rd party and should be grouped with other 3rd party packages.
Samyoul
reviewed
May 24, 2023
Comment on lines
+7
to
+16
| "context" | ||
| "fmt" | ||
| "os" | ||
| "os/signal" | ||
| "syscall" | ||
| "testing" | ||
| "time" | ||
|
|
||
| "net/http" | ||
| "net/http/httptest" |
There was a problem hiding this comment.
These are all std lib packages so can be grouped together
Samyoul
approved these changes
May 24, 2023
|
Thank you @Samyoul , done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue: #3282
status-go code depends on an external repo -
lc-proxy-wrapper, that provides functions wrapping actual nimbus-eth1 code. Relevant functionality is toggled by a build tag.