Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Browser plugin connector] Implement missing signing methods #16770

Open
alexjba opened this issue Nov 19, 2024 · 4 comments
Open

[Browser plugin connector] Implement missing signing methods #16770

alexjba opened this issue Nov 19, 2024 · 4 comments

Comments

@alexjba
Copy link
Contributor

alexjba commented Nov 19, 2024

Description

https://docs.metamask.io/wallet/concepts/signing-methods/

Methods needed:

  • eth_signTypedData_v4
  • eth_signTypedData - deprecated
  • eth_signTransaction
  • eth_sign - deprecated

https://www.notion.so/Bring-Browser-Connect-to-the-Same-Level-as-Wallet-Connect-c1f5860267df458580d9fe03d659103b

@alexjba
Copy link
Contributor Author

alexjba commented Nov 19, 2024

These methods are reported as being deprecated by Metamask. https://docs.metamask.io/wallet/concepts/signing-methods/#deprecated-signing-methods
Need to analyze if the connector should implement these methods or not

eth_signTypedData
eth_sign

cc @alaibe @saledjenic

@alexjba
Copy link
Contributor Author

alexjba commented Nov 19, 2024

The deprecated methods won't be implemented

@alexjba
Copy link
Contributor Author

alexjba commented Nov 25, 2024

eth_signTransaction is not yet supported by WC. We'll need to implement for both integrators if needed

@alexjba
Copy link
Contributor Author

alexjba commented Nov 25, 2024

@saledjenic @alaibe Need some help to determine if this is a must for 2.32, for WC and BC!

My oppinion here is that it's not a must. Currently I don't see a clear real life use case and for this and can't find a dApp or a dApp feature that requires eth_signTransaction . We've had it implemented in the initial version for WC, but was removed for the same reason: There was no clear real life dapp use case: #15661

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

No branches or pull requests

1 participant