Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include MVDS deployment in spec #27

Open
oskarth opened this issue Jul 12, 2019 · 6 comments
Open

Include MVDS deployment in spec #27

oskarth opened this issue Jul 12, 2019 · 6 comments

Comments

@oskarth
Copy link
Contributor

oskarth commented Jul 12, 2019

Considering we are going to use MVDS for v1 1:1 chats (https://github.com/status-im/bigbrother-specs/blob/master/data_sync/mvds.md), this should be reflected in the current specifications.

It is OK if we reference the MVDS spec and let it live elsewhere, but it has to be mentioned at least within some scope.

@decanus @cammellos

@oskarth
Copy link
Contributor Author

oskarth commented Oct 22, 2019

Currently the only mention of MVDS in specs we have is here

Status payloads are serialized and then wrapped inside a MVDS message which is added to an MVDS payload, this payload is then encrypted (if necessary for 1-to-1 / group-chats) and sent using whisper which also encrypts it.

Are we happy with this? If not, what changes do we want to make for this?
cc @corpetty @adambabik @cammellos @decanus

@decanus
Copy link
Contributor

decanus commented Oct 22, 2019

@oskarth, we should also mention which version of MVDS we use.

@cammellos
Copy link
Contributor

We should describe how we use groups probably, currently we just use pk1-pk2 where pks are ordered ASC , but we might want to rethink this (does not take into consideration multiple devices, which works fine, but maybe there's better)

@oskarth
Copy link
Contributor Author

oskarth commented Mar 24, 2020

Ping @decanus could you add this?

Also, are we using https://specs.vac.dev/specs/mvds-metadata.html in v1? @cammellos

@cammellos
Copy link
Contributor

We don't use metadata in the app

@decanus
Copy link
Contributor

decanus commented Mar 24, 2020

@oskarth, which part would you like me to add? the groups? I think @cammellos may have more in detail knowledge on this than I do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants