Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defaultValueDesc should be evaluated #52

Open
arnetheduck opened this issue May 31, 2022 · 0 comments
Open

defaultValueDesc should be evaluated #52

arnetheduck opened this issue May 31, 2022 · 0 comments

Comments

@arnetheduck
Copy link
Member

currently, the AST of defaultValueDesc gets pasted verbatim instead of being evaluated to a string, meaning that constants and compile-time evaluations can't be used to form it - this prevents using constants to share defaults between options and help strings, ie https://github.com/status-im/nimbus-eth2/blob/f929980bf31c3e27fa198fde2d7588293e8652ca/beacon_chain/conf.nim#L844

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant