From 7636cdfe9b8a54031b2d3b161ce595c3d696d1aa Mon Sep 17 00:00:00 2001
From: "Sverre H. Huseby" <shh@thathost.com>
Date: Tue, 1 Oct 2024 07:10:35 +0200
Subject: [PATCH] chore: add comment to describe why we clamp down a
 measurement (#223)

---
 .../io/statnett/k3a/lagexporter/ClusterLagCollector.java  | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/main/java/io/statnett/k3a/lagexporter/ClusterLagCollector.java b/src/main/java/io/statnett/k3a/lagexporter/ClusterLagCollector.java
index fee5c61..63da790 100644
--- a/src/main/java/io/statnett/k3a/lagexporter/ClusterLagCollector.java
+++ b/src/main/java/io/statnett/k3a/lagexporter/ClusterLagCollector.java
@@ -41,16 +41,20 @@ public ClusterLagCollector(final String clusterName,
     }
 
     public ClusterData collectClusterData() {
-        final boolean clientConnected = client.isConnected();
+        final boolean clientWasAlreadyConnected = client.isConnected();
         final long startMs = System.currentTimeMillis();
         final Set<String> allConsumerGroupIds = client.consumerGroupIds(consumerGroupFilter);
         final Map<TopicPartition, List<ConsumerGroupOffset>> groupOffsets = findConsumerGroupOffsets(allConsumerGroupIds);
         final Map<TopicPartition, TopicPartitionData> topicPartitionData = findTopicPartitionData(groupOffsets.keySet());
         final Map<TopicPartitionData, List<ConsumerGroupData>> topicAndConsumerData = calculateLag(groupOffsets, topicPartitionData);
         final long pollTimeMs;
-        if (clientConnected) {
+        if (clientWasAlreadyConnected) {
             pollTimeMs = System.currentTimeMillis() - startMs;
         } else {
+            /* The first cluster data collection after connecting takes an order of magnitude longer
+             * than the runs that come after. If we publish this metric, graphs in Prometheus will
+             * be scaled to a range that makes it impossible to see variations in the actual
+             * collection times. Thus, clamp it down. */
             pollTimeMs = -1;
         }
         final ClusterData clusterData = new ClusterData(clusterName, topicAndConsumerData, pollTimeMs);