Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPDSender: Validate the message size before sending metrics #5

Open
hugocosta88 opened this issue Jan 2, 2017 · 0 comments
Open

UPDSender: Validate the message size before sending metrics #5

hugocosta88 opened this issue Jan 2, 2017 · 0 comments

Comments

@hugocosta88
Copy link

hugocosta88 commented Jan 2, 2017

Context
The statful-client-vertx is exposing the config flushSize to control the number of metrics to include on each message sent to the statful server.
The size of each metric depends on its data, so attributes like tags can have a big impact on the final message size (with the same number of metrics).

Problem
Given this scenario, it is complicated to set a flushSize value that avoids sending too many messages and also doesn't reach the maximum UPD packet size.
When the message size is bigger than the maximum UDP packet size it is just rejected and the metrics are lost.

Solution proposal
The statful-cient can validate the message size before sending it and therefor reduce the number of metrics included. The metrics that doesn't fit would be sent in the next message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant