Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handy integration improvements #5576

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Handy integration improvements #5576

wants to merge 8 commits into from

Conversation

dumdum7
Copy link
Contributor

@dumdum7 dumdum7 commented Dec 27, 2024 •
edited
Loading

  • Fixes [Bug Report] Handy script starts playing before video finishes buffering #5575
  • Fixes issue where script can be unsynchronized due to video player issues. Solved by triggering a second /play API call a second after pressing play.
  • Fixes issue of timeupdate listener triggering tons of /play API calls because it doesn't wait for previous calls to finish.
  • Fixes issue of script being paused and resumed after 10 seconds due to activity tracker dependency changing.

I don't have much experience with React, so if there are better ways of doing things in React I would greatly appreciate any feedback.

@dumdum7 dumdum7 marked this pull request as draft December 27, 2024 12:52
@dumdum7 dumdum7 changed the title Fix Handy script playing before video finishes buffering Handy integration improvements Dec 27, 2024
@dumdum7
Remove unnecessary ensurePlaying() from timeupdate listener
fa96807 
Eliminates redundant API calls by only relying on playing and pause events. Handles edge cases for playback before script upload completion.
@dumdum7
Remove unnecessary video seeking event listener
a5f5110 
We don't need it anymore, listening for playing and pause events is enough.
@dumdum7
Send second play event after a play event to adjust for video player …
c768124 
…issues
@dumdum7
Fix script being paused and played after 10 seconds because of activi…
76d892f 
…ty tracker dependency change
@dumdum7 dumdum7 marked this pull request as ready for review December 29, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug Report] Handy script starts playing before video finishes buffering
1 participant
@dumdum7