Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] Excluded Tags does not apply to Identify tasks #5564

Open
bayured opened this issue Dec 20, 2024 · 0 comments
Open

[Bug Report] Excluded Tags does not apply to Identify tasks #5564

bayured opened this issue Dec 20, 2024 · 0 comments
Labels
bug report Bug reports that are not yet verified

Comments

@bayured
Copy link
Contributor

bayured commented Dec 20, 2024

Describe the bug
The Excluded Tags list is ignored when using an Identify task. The feature works as expected when scraping individually.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Settings and then Metadata Providers.
  2. Add some tags into Excluded Tag Patterns.
  3. Run an Identify task on a scene with excluded tag(s) present on scraped side.
  4. View the scene. Tag(s) in the Excluded Tags list have been scraped.

Expected behavior
Either excluded tags should document they do not apply to identify tasks or the feature should apply across all methods of scraping.

Stash Version: (from Settings -> About):
v0.27.2-37-g0621d871

Additional context
I think this broke in #2391 but haven't tested. I re-added the removed code in postProcessTags in pkg/scraper/postprocessing.go and it resolved the issue but I presume there's a cleaner way to fix but I don't understand how the identify flow works.

@bayured bayured added the bug report Bug reports that are not yet verified label Dec 20, 2024
@github-project-automation github-project-automation bot moved this to To triage in Bug fixing Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Bug reports that are not yet verified
Projects
Status: To triage
Development

No branches or pull requests

1 participant