Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Construct TableBundle for an iterable of Table objects #91

Open
jfcorbett opened this issue Feb 3, 2021 · 0 comments
Open

Construct TableBundle for an iterable of Table objects #91

jfcorbett opened this issue Feb 3, 2021 · 0 comments
Labels
ergonomics Improve usability, API, discoverability
Milestone
Version 0.1

Comments

@jfcorbett
Copy link
Member

Currently TableBundle's constructor requires a BlockIterator = Iterable[Tuple[BlockType, Optional[Any]]].
Could be nice to also allow creating a TableBundle from a plain Iterator[Table].

Currently this requires some bending backwards:

tables = [table1, table2, ...]  # each of these is a Table object
b = TableBundle((BlockType.TABLE, t) for t in tables)  # bit annoying!
@jfcorbett jfcorbett added the ergonomics Improve usability, API, discoverability label Feb 3, 2021
@guilhermebs guilhermebs added this to the Version 0.1 milestone Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ergonomics Improve usability, API, discoverability
Projects
None yet
Milestone
Version 0.1
Development

No branches or pull requests
2 participants
@jfcorbett @guilhermebs