Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'as_dataframe' option belongs in reader functions, not in TableBundle.__init__() #84

Open
jfcorbett opened this issue Dec 13, 2020 · 0 comments
Open

'as_dataframe' option belongs in reader functions, not in TableBundle.__init__() #84

jfcorbett opened this issue Dec 13, 2020 · 0 comments
Labels
ergonomics Improve usability, API, discoverability
Milestone
Version 0.1

Comments

@jfcorbett
Copy link
Member

TableBundle.__init__() currently has an as_dataframe parameter.
It is rather incongruous.
This parameter would seem to better belong in the reader functions, as one more option for their to parameter i.e. to='dataframe'. That would seem to harmonize well with the other uses of to, and rid us of the awkward asymmetry in the TableBundle.__init__() signature and implementation.
@jfcorbett jfcorbett added the ergonomics Improve usability, API, discoverability label Dec 13, 2020
@guilhermebs guilhermebs added this to the Version 0.1 milestone Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ergonomics Improve usability, API, discoverability
Projects
None yet
Milestone
Version 0.1
Development

No branches or pull requests
2 participants
@jfcorbett @guilhermebs