bug: gas type

[jbcaron]

Bug Report

types-rs version:

Current behavior:

The 'EXECUTION_RESOURCES' schema in the specification defines gas-related fields (l1_gas and l1_data_gas) as type integer. However, there is a discrepancy with the implementation in blockifier (v0.8.0), which returns these values as u128. Internally, the types used for gas values in the types-rs crate are u64, leading to inconsistency and potential type errors.

• specification: integer (undefined bit width).
• blockifier output: u128.
• types-rs internal representation: u64.

This misalignment can cause unexpected behavior and integration issues when consuming Blockifier outputs.

Expected behavior:

• the specification, blockifier, and the internal representation should use a consistent type.
• gas-related fields (l1_gas, l1_data_gas) should be defined as u128

Steps to reproduce:

Related code:

starknet-types-rpc

#[derive(Clone, Debug, Eq, Hash, PartialEq, Serialize, Deserialize)]
pub struct DataAvailability {
    /// the data gas consumed by this transaction's data, 0 if it uses gas for DA
    pub l1_data_gas: u64,
    /// the gas consumed by this transaction's data, 0 if it uses data gas for DA
    pub l1_gas: u64,
}

blockifier

#[derive(
    derive_more::Add, derive_more::Sum, Clone, Copy, Debug, Default, Eq, PartialEq, Serialize,
)]
pub struct GasVector {
    pub l1_gas: u128,
    pub l1_data_gas: u128,
}

openrpc specs

{
  "type": "object",
  "title": "DataResources",
  "description": "the data-availability resources of this transaction",
  "properties": {
    "data_availability": {
      "type": "object",
      "properties": {
        "l1_gas": {
        "title": "L1Gas",
        "description": "the gas consumed by this transaction's data, 0 if it uses data gas for DA",
        "type": "integer"
        },
        "l1_data_gas": {
          "title": "L1DataGas",
          "description": "the data gas consumed by this transaction's data, 0 if it uses gas for DA",
          "type": "integer"
        }
      }
    }
  } 
}

Other information: