From b3f7a6edddea62db8e90ae0e286665a23bf56256 Mon Sep 17 00:00:00 2001 From: Tal-Ben-Avi Date: Tue, 7 May 2024 11:52:03 +0300 Subject: [PATCH 1/2] fixing icons to have dropdown --- _data/pages/grant.yml | 5 +++++ workspaces/cms-config/src/blocks.ts | 13 ++++++++--- workspaces/cms-data/src/pages.ts | 5 +++-- .../src/components/Card/DisplayCard.tsx | 22 ++++++++++++------- 4 files changed, 32 insertions(+), 13 deletions(-) diff --git a/_data/pages/grant.yml b/_data/pages/grant.yml index a272b0bb02..fde98f7052 100644 --- a/_data/pages/grant.yml +++ b/_data/pages/grant.yml @@ -19,20 +19,25 @@ blocks: - title: Application description: "Applicants will submit proposals via an Questbook application form provided by the Starknet Foundation team. " + icon: Application - title: Internal Evaluation description: " Each application will be assessed by members of the Starknet Foundation and Starkware team based on criteria such as potential impact, innovation, milestones, community engagement & track record, and embeddedness with the Starknet ecosystem." + icon: Internal Evaluation - title: Results description: We plan to communicate decisions on your application within an approximate two week timeframe. + icon: Results - title: Onboarding description: "Upon signing a grant agreement and completing KYC, the Starknet Foundation will send funds. " + icon: Onboarding - title: Grant Deliverables description: "After completion of the work, the Foundation will assess results and share deliverables (blog post, video, AMA) with the team. " + icon: Post Grant Check-in - type: container blocks: - type: flex_layout diff --git a/workspaces/cms-config/src/blocks.ts b/workspaces/cms-config/src/blocks.ts index 19a2832dcc..dcbfdfa401 100644 --- a/workspaces/cms-config/src/blocks.ts +++ b/workspaces/cms-config/src/blocks.ts @@ -263,10 +263,17 @@ export const cardDisplayItem = [ crowdin: false, }, { - label: "Image", + label: "Icon", required: false, - name: "image", - widget: "image", + name: "icon", + widget: "select", + options: [ + "Application", + "Internal Evaluation", + "Results", + "Onboarding", + "Post Grant Check-in", + ], crowdin: false, }, ] satisfies CmsField[]; diff --git a/workspaces/cms-data/src/pages.ts b/workspaces/cms-data/src/pages.ts index 2e19aef0cd..ac89cf521d 100644 --- a/workspaces/cms-data/src/pages.ts +++ b/workspaces/cms-data/src/pages.ts @@ -67,12 +67,13 @@ export interface ListCardItems { } export interface DisplayCardItems { - title: + title: string; + selectedIcon?: | "Application" | "Internal Evaluation" | "Results" | "Onboarding" - | "Grant Deliverables"; + | "Post Grant Check-in"; description: string; image?: string; } diff --git a/workspaces/website/src/components/Card/DisplayCard.tsx b/workspaces/website/src/components/Card/DisplayCard.tsx index 10dcc5a424..681007f764 100644 --- a/workspaces/website/src/components/Card/DisplayCard.tsx +++ b/workspaces/website/src/components/Card/DisplayCard.tsx @@ -7,12 +7,13 @@ import { Results } from "@ui/Icons/DisplayCardIcons/Results"; import { Heading } from "@ui/Typography/Heading"; type Props = { - readonly title: + readonly title: string; + readonly icon?: | "Application" | "Internal Evaluation" | "Results" | "Onboarding" - | "Grant Deliverables"; + | "Post Grant Check-in"; readonly description?: string; readonly index: number; } & BoxProps; @@ -22,10 +23,15 @@ const images = { "Internal Evaluation": , Results: , Onboarding: , - "Grant Deliverables": , + "Post Grant Check-in": , }; -export const DisplayCard = (props: Props) => { +export const DisplayCard = ({ + title, + icon = "Application", + description, + index, +}: Props) => { return ( { _dark={{ color: "white" }} marginBottom={{ base: "16px", md: "0" }} > - {images[props?.title]} + {images[icon]} @@ -71,7 +77,7 @@ export const DisplayCard = (props: Props) => { _dark={{ bg: "white", color: "black" }} color="white" > - {props.index} + {index} { color: "button-nav-fg", }} > - {props.title} + {title} - {props.description} + {description} From b0e0ccc503839ac3b43758b6b9fdd44ae4506ba9 Mon Sep 17 00:00:00 2001 From: Tal-Ben-Avi Date: Tue, 7 May 2024 12:13:07 +0300 Subject: [PATCH 2/2] fixing icon --- workspaces/cms-data/src/pages.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/workspaces/cms-data/src/pages.ts b/workspaces/cms-data/src/pages.ts index ac89cf521d..9392ad7da6 100644 --- a/workspaces/cms-data/src/pages.ts +++ b/workspaces/cms-data/src/pages.ts @@ -68,7 +68,7 @@ export interface ListCardItems { export interface DisplayCardItems { title: string; - selectedIcon?: + icon?: | "Application" | "Internal Evaluation" | "Results"