feat: edit tabs names #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cairo-playground ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for starknet-playground ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feature: Enable editing tabs' names.
Only 1 tab's name can be edited at a time.
DC for editing, also makes that tab 'active'.
The name gets saved in the context only at the 'EDIT_TAB_NAME' action,
Gets triggered at 'Enter' keypress or blur (not on each keypress).
The action triggers only if
newTabName && newTabName !== prevTabNameNavItem.js got an inner state, perhaps should be moved in the folders-tree
Changes have been done against master branch, and PR does not conflict
Docs have been updated
PR title is follow the standard-version convention:
<type>(optional subject): <description>, e.g:fix: minor typos in code