Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disconnect doesn't seem to work #123

Open
shramee opened this issue Aug 19, 2022 · 2 comments
Open

Disconnect doesn't seem to work #123

shramee opened this issue Aug 19, 2022 · 2 comments

Comments

@shramee
Copy link

shramee commented Aug 19, 2022

Disconnecting after connecting doesn't work,

import {connect, disconnect} from "get-starknet";

// Doesn't work
disconnect();

// Neither does this
disconnect( {clearDefaultWallet: true} );

// Nor this
disconnect( {clearLastWallet: true, clearDefaultWallet: true} );

On the next session (in another tab or revisiting later), checking user login status still returns the wallet.

connect( {showList: false} ).then( wallet => {
	wallet
		?.enable( {showModal: false} )
		.then( () => _onConnectedStatusChange( wallet ) );
} );
@shramee
Copy link
Author

shramee commented Aug 20, 2022

I think I might be misunderstanding the way this works.
I am associating it with the typical login/logout process assuming connect would try to get the login state from the cookies/storage. But it might be doing what it's supposed to.

This isn't a biggie for us atm anyway.

@Metronomy
Copy link

Are there any updates on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants