Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert tests resources to fixtures #106

Open
scardena opened this issue Apr 20, 2022 · 0 comments
Open

convert tests resources to fixtures #106

scardena opened this issue Apr 20, 2022 · 0 comments

Comments

@scardena
Copy link
Collaborator

scardena commented Apr 20, 2022

We are creating resources and making sure they are destroyed as part of multiple tests (for example we create users, roles, databases, datasources, virtual graphs, and others)
if a test fails, then the resource can be left dangling. one way to approach this (which is currently what we are doing) is to run a test, and depending on the result, clean the resources.
This would be much easier, readable, and make the code smaller, if we would be using pytest fixtures for it.
We already added virtual graph and datasources for some tests in here: #103 , but we are are still missing some other fixtures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant