Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance audit/improvements #16

Open
jmrog opened this issue Jan 29, 2019 · 0 comments
Open

Performance audit/improvements #16

jmrog opened this issue Jan 29, 2019 · 0 comments

Comments

@jmrog
Copy link
Contributor

jmrog commented Jan 29, 2019

It would be good to buckle down a bit and make sure that we're doing things as efficiently as possible. Some example areas where there's likely room for easy improvement:

  1. It likely makes sense to code-split each parser into its own bundle, rather than always bundling them all together. This will improve loading times. Covered by Split each parser into a separate bundle #31.
  2. Our utils/regex helper always uses capturing groups, but this is almost never necessary. Non-capturing groups should be more performant.
  3. The visitor in the SrsParser likely visits more nodes than necessary; there are probably opportunities to short-circuit.
@jmrog jmrog added enhancement New feature or request research/discussion labels Jan 29, 2019
@sfkrauss sfkrauss added techdebt and removed enhancement New feature or request labels Aug 5, 2019
@jmrog jmrog added the good first issue Good for newcomers label Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants