Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FlexiDag] replace NodeHandle::get_dag function name with NodeHandle::blockDag #4058

Open
nkysg opened this issue May 13, 2024 · 0 comments
Open
Labels
enhancement Enhancement

Comments

@nkysg
Copy link
Collaborator

nkysg commented May 13, 2024

We can see previous code

    pub fn txpool(&self) -> TxPoolService {
        self.registry
            .get_shared_sync::<TxPoolService>()
            .expect("TxPoolService must exist.")
    }
    pub fn get_dag(&self) -> Result<BlockDAG> {
        self.registry
            .get_shared_sync::<BlockDAG>()
            .map_err(|e| format_err!("Get BlockDAG error: {:?}", e))
    }

may be blockDag(&self) is better than get_dag

@nkysg nkysg added the enhancement Enhancement label May 13, 2024
@nkysg nkysg changed the title [FlexiDag] NodeHandle::get_dag function name [FlexiDag] replace NodeHandle::get_dag function name with NodeHandle::blockDag May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement
Projects
None yet
Development

No branches or pull requests

1 participant