Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[P0] Additional intervention arguments are not saved correctly, e.g. add_bias #82

Open
frankaging opened this issue May 10, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@frankaging
Copy link
Collaborator

Descriptions:

For customizable interventions, people might want to save the interventions with their customized arguments. For instance, the dropout ratio, the activation function type or whether to add a special bias term to any projection matrix. Currently, these additional arguments are not saved.

The main change will be done in pyvene tracked by this parent PR: stanfordnlp/pyvene#157. After the parent PR is checked in, we should also verify pyreft works with updated pyvene library.

@frankaging frankaging assigned frankaging and AmirZur and unassigned frankaging May 10, 2024
@frankaging frankaging added the bug Something isn't working label May 10, 2024
@frankaging frankaging changed the title [P0] Addition intervention arguments are not saved correctly, e.g. add_bias [P0] Additional intervention arguments are not saved correctly, e.g. add_bias May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants