Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for non-almond datasets #231

Open
Mehrad0711 opened this issue Nov 30, 2021 · 0 comments
Open

Support for non-almond datasets #231

Mehrad0711 opened this issue Nov 30, 2021 · 0 comments
Labels
good first issue Good for newcomers

Comments

@Mehrad0711
Copy link
Member

Mehrad0711 commented Nov 30, 2021

Through several rounds of changes we've made so far, the generic datasets (originally part of decaNLP) cannot be loaded properly in genienlp anymore and should be fixed.
Also, many of those datasets (e.g. iwslt, sst, squad, imdb) are now part of datasets library. We should remove those obsolete implementations and associated metrics, and import them from datasets instead.
We have added support to load new datasets from HF datasets. Check out https://github.com/stanford-oval/genienlp/blob/master/genienlp/tasks/hf_dataset.py for the implementation.

@Mehrad0711 Mehrad0711 added bug Something isn't working good first issue Good for newcomers labels Nov 30, 2021
@Mehrad0711 Mehrad0711 removed the bug Something isn't working label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant