Skip to content
This repository has been archived by the owner on Nov 5, 2019. It is now read-only.

Remove Alamofire dependency and use native networking library #33

Open
moughxyz opened this issue Feb 27, 2017 · 8 comments
Open

Remove Alamofire dependency and use native networking library #33

moughxyz opened this issue Feb 27, 2017 · 8 comments

Comments

@moughxyz
Copy link
Member

I'm beginning an effort to trim down dependencies cross platform in the name of longevity. There's an easy opportunity here to remove Alamofire and use NSURLSession or NSURLConnection.

@jz709u
Copy link
Contributor

jz709u commented Mar 13, 2017

I'll start working on this I've been really busy lately. Not many contributions lately

@moughxyz
Copy link
Member Author

No worries, I think this one can be an easy win.

@JacobBoyd
Copy link

@jz709u Have you started on this issue/help wanted? If not I would like to start contributing to the project by tackling this @mobitar.

@moughxyz
Copy link
Member Author

moughxyz commented May 31, 2017 via email

@flowinho
Copy link

The native networking methods can really be quite buggy.
Sounds like a great improvement though.
Would you like some help @JacobBoyd ?

@JacobBoyd
Copy link

Sorry guys, I am starting the this issue now. I was kinda of busy for a while. I will keep this thread updated as I make progress!

@JacobBoyd
Copy link

JacobBoyd commented Aug 30, 2017

I have set up

GET(_ url: String, parameters: [String: Any], completionHandler: @escaping(_ response: Data) -> (), errorHandler: @escaping(_ error: Error) -> ())

and

POST(_ url: String, parameters: [String : Any], completionHandler: @escaping(_ response: Data) -> (), errorHandler: @escaping(_ error: Error)->()) -> Void

Methods for the new class StandardNotesURLSession. I am working on error handling and accepted http status codes. I am also planning to create a .download() for the class.

@moughxyz
Copy link
Member Author

Feel free to submit the pull request at any time, even if it's still a WIP. This way others can follow along.

I am also planning to create a .download() for the class.

How would that work?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants