Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support eslint-plugin-n 17 #412

Open
otto-liljalaakso-nt opened this issue Apr 30, 2024 · 9 comments
Open

Support eslint-plugin-n 17 #412

otto-liljalaakso-nt opened this issue Apr 30, 2024 · 9 comments

Comments

@otto-liljalaakso-nt
Copy link

otto-liljalaakso-nt commented Apr 30, 2024

Here's what I did

I have a project that declares both eslint-config-standard and eslint-plugin-n as dev dependencies. Periodically, I upgrade all dependencies to latest versions I can. Today's attempt produced this:

"devDependencies": {
    "eslint-config-standard": "^17.1.0",
    "eslint-plugin-n": "^17.4.0",
}

What I expected to happen

npm install works and all the linting stuff still works.

What seems to have happened

eslint-config-standard does not support eslint-plugin-n version 17:

$  npm install
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/eslint-plugin-n
npm ERR!   dev eslint-plugin-n@"^17.4.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer eslint-plugin-n@"^15.0.0 || ^16.0.0 " from [email protected]
npm ERR! node_modules/eslint-config-standard
npm ERR!   dev eslint-config-standard@"^17.1.0" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: [email protected]
npm ERR! node_modules/eslint-plugin-n
npm ERR!   peer eslint-plugin-n@"^15.0.0 || ^16.0.0 " from [email protected]
npm ERR!   node_modules/eslint-config-standard
npm ERR!     dev eslint-config-standard@"^17.1.0" from the root project
@skew202
Copy link

skew202 commented May 1, 2024

Similar issue with eslint@9 upgrade

npm ERR! While resolving: @repository
npm ERR! Found: [email protected]
npm ERR! node_modules/eslint
npm ERR!   dev eslint@"^9.1.1" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer eslint@"^8.0.1" from [email protected]
npm ERR! node_modules/eslint-config-standard
npm ERR!   dev eslint-config-standard@"^17.1.0" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

@mahula
Copy link

mahula commented May 15, 2024

We have the same issue upgrading eslint-plugin-n to a 17.x version.
There is a renovate update PR.

But it seems since month only the renovate bot is committing on this repo.

@mahula
Copy link

mahula commented May 15, 2024

Similar issue with eslint@9 upgrade

There is a renovate update PR waiting

@amk221
Copy link

amk221 commented May 20, 2024

Would love this too please

@yoyo837
Copy link

yoyo837 commented Jun 11, 2024

Similar issue with eslint@9 upgrade

There is a renovate update PR waiting

It just a robot.

@CaptainGlac1er
Copy link

It looks like 16 is EOL according to https://www.npmjs.com/package/eslint-plugin-n

@jeromy-cannon
Copy link

would appreciate if some of the maintainers would take some time for this, thank you!

@voxpelli
Copy link
Member

@jeromy-cannon I'm spending my time over at https://github.com/neostandard/neostandard now – it works great with latest eslint-plugin-n and I won't personally do any work on standard here until we hopefully reconcile the projects at a future date

@jeromy-cannon
Copy link

@jeromy-cannon I'm spending my time over at https://github.com/neostandard/neostandard now – it works great with latest eslint-plugin-n and I won't personally do any work on standard here until we hopefully reconcile the projects at a future date

thank you for dropping a line. I'll check out neostandard and see how it fits in my project, thanks for the recommendation and explanation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

8 participants