Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regex lint error because of this dependency when using standard #20

Open
duncdrum opened this issue Jun 7, 2021 · 0 comments
Open

regex lint error because of this dependency when using standard #20

duncdrum opened this issue Jun 7, 2021 · 0 comments

Comments

@duncdrum
Copy link

duncdrum commented Jun 7, 2021

What version of this package are you using?
tested on 12, and 14

What operating system, Node.js, and npm version?
macOS 11
tested with node 10, 15

What happened?
Running standard produces this error

npx standard --fix                                                                                                                                                 ✔ 
/Users/halalpha/Documents/exist-gitlab/documentation/node_modules/deglob/node_modules/ignore/index.js:307
    ? new RegExp(source, 'i')
      ^

SyntaxError: Invalid regular expression: /(?:^|\/)hs_err_pid[^\/]*\(?=$|\/$)/: Unmatched ')'
    at new RegExp (<anonymous>)
    at makeRegex (/Users/halalpha/Documents/exist-gitlab/documentation/node_modules/deglob/node_modules/ignore/index.js:307:7)
    at createRule (/Users/halalpha/Documents/exist-gitlab/documentation/node_modules/deglob/node_modules/ignore/index.js:355:17)
    at Ignore._addPattern (/Users/halalpha/Documents/exist-gitlab/documentation/node_modules/deglob/node_modules/ignore/index.js:423:20)
    at Array.forEach (<anonymous>)
    at Ignore.add (/Users/halalpha/Documents/exist-gitlab/documentation/node_modules/deglob/node_modules/ignore/index.js:437:7)
    at Ignore.addPattern (/Users/halalpha/Documents/exist-gitlab/documentation/node_modules/deglob/node_modules/ignore/index.js:450:17)
    at /Users/halalpha/Documents/exist-gitlab/documentation/node_modules/deglob/index.js:109:25
    at Array.forEach (<anonymous>)
    at parseOpts (/Users/halalpha/Documents/exist-gitlab/documentation/node_modules/deglob/index.js:108:18)

What did you expect to happen?
standard to ling files

Are you willing to submit a pull request to fix this bug?
if someone can confirm that the expression should be /(?:^|\/)hs_err_pid[^\/]*\(?=$|\/$\)/ yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant