Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linux wheels are not tested #51

Closed
riddell-stan opened this issue Oct 27, 2020 · 2 comments
Closed

Linux wheels are not tested #51

riddell-stan opened this issue Oct 27, 2020 · 2 comments
Labels
enhancement help wanted

Comments

@riddell-stan
Copy link
Contributor

riddell-stan commented Oct 27, 2020 •
edited
Loading

Linux wheels are not tested. Testing linux wheels was removed in commit 8a10103

Linux wheels are working fine on Ubuntu 20.04. They do not work on Ubuntu 18.04. There is no way to use multibuild to test the wheels on Ubuntu 20.04.

Right now we are assuming that if the wheels pass tests on macOS they will also pass tests on Ubuntu 20.04.
@riddell-stan riddell-stan pinned this issue Dec 7, 2020
@riddell-stan
Copy link
Contributor Author

It's likely not too difficult to switch to cibuildwheel. See osmcode/pyosmium-wheel-build#14

If we switched to cibuildwheel we could eliminate this repository entirely.

@riddell-stan riddell-stan mentioned this issue Mar 28, 2021
Closed
@riddell-stan
Copy link
Contributor Author

Closed in #82

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@riddell-stan