-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release CmdStan 2.34 #1230
Comments
are we creating tarballs for Google Colab? |
Yes, @serban-nicusor-toptal makes one each release (usually not for RCs, I don’t believe) |
I build it always, for RC also. I have some credits and wrote a script so it's fairly easy to do. |
Good morning @WardBrian, are we still waiting for stan-dev/stan#3249 ? |
Let's give it a few hours to see if we can get #1234 |
Sounds good, we can also postpone for the following days if #1234 is important. |
@serban-nicusor-toptal you should be good to run the RCs as soon as the currently-running jenkins pipelines finish. I'll get started on the release notes and a draft of the blog post. |
Here's my working draft of the release notes: https://gist.github.com/WardBrian/e3a6b534f6220df5439df05f08445584 And the discourse announcement: https://gist.github.com/WardBrian/1ba59bfd0037d3a721efac8934e4ad36 @rok-cesnovar is helping me with the discourse post, it should be ready to go up as soon as the tarballs are ready |
Jenkins finished all develop jobs, I'll start shortly. |
Release candidates are up! We were a bit unfortunate with the Jenkins maintenance timing so we'll have to wait until it's online for the non-x64 binaries builds. I'll watch it and do it later when it's back. |
Running cmdstanpy tests here: https://github.com/stan-dev/cmdstanpy/actions/runs/7453476403 Discourse post is up: https://discourse.mc-stan.org/t/cmdstan-stan-2-34-release-candidate/33756 |
Cmdstanpy tests have a failure because the I think this is better classified as a cmdstanpy bug |
stanc3 and cmdstan binaries are now ready! |
CmdStanPy tests passed: https://github.com/stan-dev/cmdstanpy/actions/runs/7464824088 @rok-cesnovar @andrjohns can one of you queue a run of the cmdstanr tests? |
I ran the CmdStanR tests: https://github.com/stan-dev/cmdstanr/actions/runs/7477267203/job/20349538347 13 failures, but I'm having a hard time telling if they're relevant or not. @rok-cesnovar @andrjohns @jgabry can you weigh in on those tests? |
Looking at it quickly, they look fine, mostly around model code that errors now. Will eliminate them before we do the actual release. |
Unless something comes in over the long weekend, we should be good to release Tuesday |
I will create the release branches later today, add the release notes then create a merge to develop for all repos. This so the pipelines will finish until tomorrow morning. |
You can find all the open PRs targeting
It would be great if someone else could take a look then we're free to merge them in. |
Good morning, the release is out now! https://github.com/stan-dev/math/releases/tag/v4.8.0 Please find and review the docs PRs: |
Thanks @serban-nicusor-toptal! I'll work with @rok-cesnovar on getting a blog post up |
Blog, Twitter/X and Discourse posts are up. Thanks @WardBrian for writing the blog post and RC announcement. I think we can close this one. I will get the constant tests to turn green by the end of the week. The failures are all false positives, so we are all good. |
Everything is almost ready! I'll get home in a few hours and will do the last thing, merge develop into master for math, stan, cmdstan. |
The last-minute doc changes have been built and are now live on the website |
Good morning, looks like we have some failures in CI Do we release a patch version for stan-dev/math#3002 ? |
stan-dev/math#3002 isn't mission-critical enough for a patch release on its own in my opinion, but if we find reason to do one we'd want to make sure it was in there alongside whatever else I think those test failures are due to issues in the PRs, starting with the conflicts @andrjohns noticed in the Math PR. Is there a reason why we merge the release branch, rather than |
The only difference between |
The CI pipeline ignores the submodules anyway, I believe. I think the correct way to do this is develop -> master in math, then develop -> master in Stan, then develop -> master here. I also think it would be reasonable if after each release we just did a |
That sounds good, I'll make a note for next time.
|
assuming that works, I think that's what we actually want to happen. |
That's now done! Let's hope everything goes smoothly! |
#1238 is probably worthy of a patch. We should wait if anything else comes up too. |
stan-dev/stan#3255 and stan-dev/stan#3251 would also go into 2.34.1 Nothing in Math at the moment |
Tentative 2.34.1 release notes: CmdStan
Stan
|
@serban-nicusor-toptal Does monday work for you to run the patch release? Currently it would only be for the stan and cmdstan repos - math and stanc3 should be re-used from |
Hey Brian, Monday is fine with me! |
We're also waiting to see if stan-dev/math#3002 is merged. If so, it would be nice to cherry pick a math patch release. |
@serban-nicusor-toptal the pr to watch is now stan-dev/math#3007 This is targetting a branch called We can then merge the release branch back into develop of math. |
Ok, I just put up #1243 which will hopefully be merged today, release tomorrow. Here are the notes: Math (releasing from branch
Stan (releasing from
CmdStan (releasing from
|
Good morning, patch release is ready! https://github.com/stan-dev/math/releases/tag/v4.8.1 With PRs targeting develop stan-dev/math#3011 After PRs are approved & merged, I will align develop branch with master and that should be the last bit! |
With 2.34.1 out I think we can close this issue. Thank you to everyone who helped with this release! |
I have made https://github.com/stan-dev/math/tree/staging/v4.8.2, which currently contains cherry-picks of stan-dev/math#3012 and stan-dev/math#3014 I believe it may be worth doing a .2 for these fixes. We can discuss when it would happen |
Feature freeze (January 8th, 2024):
Release (January 16th, 2024):
The text was updated successfully, but these errors were encountered: