Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facets argument of facet_grid() deprecated #322

Closed
joannalingzj opened this issue Apr 9, 2024 · 2 comments
Closed

Facets argument of facet_grid() deprecated #322

joannalingzj opened this issue Apr 9, 2024 · 2 comments

Comments

@joannalingzj
Copy link

Hi,
I was running mcmc_acf and got this warning message.
mcmc_acf(posterior_b5, pars = c("b_Intercept","b_time","sd_Batch__Intercept","sd_Batch__time","sigma"), lags = 20)
Warning message:
The facets argument of facet_grid() is deprecated as of ggplot2 2.2.0.
ℹ Please use the rows argument instead.
ℹ The deprecated feature was likely used in the bayesplot package.
Please report the issue at https://github.com/stan-dev/bayesplot/issues/.
This warning is displayed once every 8 hours.
Call lifecycle::last_lifecycle_warnings() to see where this warning was generated.

lifecycle::last_lifecycle_warnings()
[[1]]
<warning/lifecycle_warning_deprecated>
Warning:
The facets argument of facet_grid() is deprecated as of ggplot2 2.2.0.
ℹ Please use the rows argument instead.
ℹ The deprecated feature was likely used in the bayesplot package.
Please report the issue at https://github.com/stan-dev/bayesplot/issues/.


Backtrace:

  1. └─bayesplot::mcmc_acf(...)
  2. └─bayesplot:::.mcmc_acf(...)
  3. ├─base::do.call(facet_fun, facet_args)
    
  4. └─ggplot2::facet_grid(facets = "Chain ~ Parameter")
    
  5.   └─ggplot2:::deprecate_warn0("2.2.0", "facet_grid(facets)", "facet_grid(rows)")
    
@jgabry
Copy link
Member

jgabry commented Apr 10, 2024

Thanks for reporting this!

@jgabry
Copy link
Member

jgabry commented Jul 31, 2024

Coming back to this, I think this was actually fixed in #305. So it shouldn't produce a warning in the latest version of bayesplot. If it still does we can reopen this and look into it.

@jgabry jgabry closed this as completed Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants