From d97e7d914ef4e90895df73df89abcee0ce8a463b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Teemu=20S=C3=A4ilynoja?= <teemu.sailynoja@gmail.com>
Date: Fri, 19 Jan 2024 16:07:19 +0200
Subject: [PATCH] Updated y-axis label on ecdf difference plots.

---
 R/ppc-distributions.R                                         | 4 ++--
 tests/testthat/_snaps/ppc-distributions/ppc-pit-ecdf-diff.svg | 2 +-
 .../_snaps/ppc-distributions/ppc-pit-ecdf-grouped-diff.svg    | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/R/ppc-distributions.R b/R/ppc-distributions.R
index 73b32e34..eb0f0f31 100644
--- a/R/ppc-distributions.R
+++ b/R/ppc-distributions.R
@@ -647,7 +647,7 @@ ppc_pit_ecdf <- function(y,
       color = "yrep"
     ),
     linetype = 2, show.legend = FALSE) +
-    labs(y = "ECDF", x = "PIT") +
+    labs(y = ifelse(plot_diff,"ECDF - difference","ECDF"), x = "PIT") +
     yaxis_ticks(FALSE) +
     scale_color_ppc() +
     bayesplot_theme_get()
@@ -735,7 +735,7 @@ ppc_pit_ecdf_grouped <-
         color = "yrep"
       ),
       linetype = 2, show.legend = FALSE) +
-      labs(y = "ECDF", x = "PIT") +
+      labs(y = ifelse(plot_diff,"ECDF - difference","ECDF"), x = "PIT") +
       yaxis_ticks(FALSE) +
       bayesplot_theme_get() +
       facet_wrap("group") +
diff --git a/tests/testthat/_snaps/ppc-distributions/ppc-pit-ecdf-diff.svg b/tests/testthat/_snaps/ppc-distributions/ppc-pit-ecdf-diff.svg
index f5f91cd0..c8888419 100644
--- a/tests/testthat/_snaps/ppc-distributions/ppc-pit-ecdf-diff.svg
+++ b/tests/testthat/_snaps/ppc-distributions/ppc-pit-ecdf-diff.svg
@@ -51,7 +51,7 @@
 <text x='524.53' y='554.29' text-anchor='middle' style='font-size: 9.60px; fill: #4D4D4D; font-family: sans;' textLength='18.69px' lengthAdjust='spacingAndGlyphs'>0.75</text>
 <text x='683.46' y='554.29' text-anchor='middle' style='font-size: 9.60px; fill: #4D4D4D; font-family: sans;' textLength='18.69px' lengthAdjust='spacingAndGlyphs'>1.00</text>
 <text x='377.83' y='567.53' text-anchor='middle' style='font-size: 12.00px; font-family: sans;' textLength='18.67px' lengthAdjust='spacingAndGlyphs'>PIT</text>
-<text transform='translate(14.24,283.58) rotate(-90)' text-anchor='middle' style='font-size: 12.00px; font-family: sans;' textLength='32.67px' lengthAdjust='spacingAndGlyphs'>ECDF</text>
+<text transform='translate(14.24,283.58) rotate(-90)' text-anchor='middle' style='font-size: 12.00px; font-family: sans;' textLength='96.04px' lengthAdjust='spacingAndGlyphs'>ECDF - difference</text>
 <text x='41.64' y='15.89' style='font-size: 14.40px; font-family: sans;' textLength='114.47px' lengthAdjust='spacingAndGlyphs'>ppc_pit_ecdf (diff)</text>
 </g>
 </svg>
diff --git a/tests/testthat/_snaps/ppc-distributions/ppc-pit-ecdf-grouped-diff.svg b/tests/testthat/_snaps/ppc-distributions/ppc-pit-ecdf-grouped-diff.svg
index b3329c23..a62e2778 100644
--- a/tests/testthat/_snaps/ppc-distributions/ppc-pit-ecdf-grouped-diff.svg
+++ b/tests/testthat/_snaps/ppc-distributions/ppc-pit-ecdf-grouped-diff.svg
@@ -151,7 +151,7 @@
 <polyline points='38.65,434.61 41.64,434.61 ' style='stroke-width: 0.64; stroke: #333333; stroke-linecap: butt;' />
 <polyline points='38.65,370.80 41.64,370.80 ' style='stroke-width: 0.64; stroke: #333333; stroke-linecap: butt;' />
 <text x='377.83' y='567.53' text-anchor='middle' style='font-size: 12.00px; font-family: sans;' textLength='18.67px' lengthAdjust='spacingAndGlyphs'>PIT</text>
-<text transform='translate(14.24,293.20) rotate(-90)' text-anchor='middle' style='font-size: 12.00px; font-family: sans;' textLength='32.67px' lengthAdjust='spacingAndGlyphs'>ECDF</text>
+<text transform='translate(14.24,293.20) rotate(-90)' text-anchor='middle' style='font-size: 12.00px; font-family: sans;' textLength='96.04px' lengthAdjust='spacingAndGlyphs'>ECDF - difference</text>
 <text x='41.64' y='15.89' style='font-size: 14.40px; font-family: sans;' textLength='175.33px' lengthAdjust='spacingAndGlyphs'>ppc_pit_ecdf_grouped (diff)</text>
 </g>
 </svg>