Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Space image cache is wrong #119

Closed
ChaituVR opened this issue Nov 21, 2023 · 4 comments · May be fixed by #171
Closed

Space image cache is wrong #119

ChaituVR opened this issue Nov 21, 2023 · 4 comments · May be fixed by #171
Labels
bug Something isn't working

Comments

@ChaituVR
Copy link
Contributor

In some cases, even if we pass new cb param, the image stored in cache is old avatar

Example https://cdn.stamp.fyi/space/wen🌕.eth?s=96&cb=c178562f8f12066b here is this case c178562f8f12066b belong to new image hash but somehow in cache we still have old image

i may delete the cache soon so for future reference:

when i visit link above, I see this
image

if i change cb to something else it works
image

On UI cb is generated with const hash = sha256(props.space.avatar).slice(0, 16);
while props.space.avatar value is ipfs://bafybeiatkvzda3w6xquzv2dkn5gn7f3jrfarxh6bwy5t3lid2hut5qooie
@ChaituVR ChaituVR mentioned this issue Nov 21, 2023
Merged
@wa0x6e wa0x6e added the bug Something isn't working label Dec 4, 2023
@wa0x6e wa0x6e assigned wa0x6e and unassigned wa0x6e Feb 1, 2024
@wa0x6e wa0x6e mentioned this issue Feb 11, 2024
Open
@Sekhmet
Copy link
Contributor

Sekhmet commented Aug 8, 2024

Do we have some more recent example of broken cache? The one in the task no longer works.

@wa0x6e
Copy link
Contributor

wa0x6e commented Aug 8, 2024

I’ve never been able to reproduce the issue.

My take on solving this was to refactor the code, to extract the cache engine

@Sekhmet
Copy link
Contributor

Sekhmet commented Aug 8, 2024

We had bug that could cause it, but it should have been solved before this issue was created so I'm not sure: #55

Ideally we should have repro so we can see if what we do actually fixes it, without it I don't think I'd bother.

@Sekhmet
Copy link
Contributor

Sekhmet commented Sep 26, 2024

We can reopen if we reproduce it.

@Sekhmet Sekhmet closed this as not planned Won't fix, can't repro, duplicate, stale Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: extract cache logic into dedicated class stamp-labs/stamp
3 participants
@wa0x6e @Sekhmet @ChaituVR