Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

English VCCV Phonemizer error for the word "desktop" #1259

Open
1 task done
Myuqou opened this issue Aug 27, 2024 · 2 comments
Open
1 task done

English VCCV Phonemizer error for the word "desktop" #1259

Myuqou opened this issue Aug 27, 2024 · 2 comments

Comments

@Myuqou
Copy link

Myuqou commented Aug 27, 2024

Acknowledgement

  • I have read Getting-Started and FAQ

🐛 Describe the bug

When the word "desktop" is entered into a note when using the English VCCV Phonemizer, the word is unable to be phonemized which results in an error.

I messed around a bit with the code and it looks like the issue can be fixed by adding {"skt", "sk"} to the vcccExceptions list in the EnglishVCCVPhonemizer.cs file.

It seems like something that makes an "skt" phoneme is pretty rare in English as "desktop" and "desktops" were the only words I could find that has this problem, which is why it may have been overlooked up to this point. That said, I don't fully understand the logic behind the phonemizer so someone who knows what they are doing should probably take a closer look at this.

Explains how to reproduce the bug

  1. Load a English VCCV Singer and set the phonemizer to EN VCCV.
  2. Make a note and set the lyric to "desktop" without the quotes

OS & Version

Windows 10

Logs

2024-08-27 16:23:07.582 -07:00 [ERR] phonemizer error desktop
System.Collections.Generic.KeyNotFoundException: The given key 'skt' was not present in the dictionary.
at System.Collections.Generic.Dictionary2.get_Item(TKey key) at OpenUtau.Plugin.Builtin.EnglishVCCVPhonemizer.ProcessSyllable(Syllable syllable) in C:\projects\openutau\OpenUtau.Plugin.Builtin\EnglishVCCVPhonemizer.cs:line 413 at OpenUtau.Plugin.Builtin.SyllableBasedPhonemizer.Process(Note[] notes, Nullable1 prev, Nullable1 next, Nullable1 prevNeighbour, Nullable`1 nextNeighbour, Note[] prevNeighbours) in C:\projects\openutau\OpenUtau.Plugin.Builtin\SyllableBasedPhonemizer.cs:line 164
at OpenUtau.Api.PhonemizerRunner.Phonemize(PhonemizerRequest request) in C:\projects\openutau\OpenUtau.Core\Api\PhonemizerRunner.cs:line 168

@BagelHero
Copy link
Contributor

Woah, good catch! That phonemizers' author is currently on a break I believe, but that sounds like you've found the correct solution.
If you still have the fork, feel free to send through a pull request and it'll go through to beta in a week or three (we just have a bit of a slow turn around), else one of our regular contributors (or myself) will make sure it gets fixed if you don't have the time :)

Repository owner deleted a comment Sep 3, 2024
Copy link

github-actions bot commented Nov 2, 2024

This issue is stale because it has been open for 60 days with no activity. It will be closed if no further activity occurs. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants