Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Modified theme common for header and footer sa 5384 #8

Conversation

RSAK56
Copy link
Contributor

@RSAK56 RSAK56 commented Mar 14, 2024

Description

  1. Modified header and footer for MTO docs theme common
  2. Adjusted dark and light theme
  3. Modified body content
  4. Shifted content to theme common

Fixes # (issue)
UI/UX / Theme update

Type of change

Enhancement

  • Bug fix (non-breaking change which fixes an issue)
  • UI/UX modification
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@RSAK56 RSAK56 added the enhancement New feature or request label Mar 14, 2024
@RSAK56 RSAK56 self-assigned this Mar 14, 2024
mkdocs.yml Outdated Show resolved Hide resolved
mkdocs.yml Show resolved Hide resolved
mkdocs.yml Show resolved Hide resolved
resources/assets/images/logo-dark.png Outdated Show resolved Hide resolved
resources/assets/images/magnify.png Outdated Show resolved Hide resolved
resources/assets/svg/down-arrow.svg Outdated Show resolved Hide resolved
resources/main.html Show resolved Hide resolved
@ufateh
Copy link
Contributor

ufateh commented Mar 27, 2024

going to merge this now

@RSAK56 RSAK56 requested a review from ufateh March 27, 2024 10:15
Copy link
Contributor

@ufateh ufateh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving this, we had the initial demo and it looks fine apart from few improvements like fonts, alignment which is minor atm.

@karl-johan-grahn karl-johan-grahn merged commit 6625223 into main Apr 1, 2024
4 checks passed
@karl-johan-grahn karl-johan-grahn deleted the task/modify-ui-design-mto-docs-header-footer-theme-common-sa-5384 branch April 1, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants