Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add simple example notebook #87

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Add simple example notebook #87

merged 2 commits into from
Sep 19, 2023

Conversation

gadomski
Copy link
Contributor

Related issues

Description

Simple skeleton of what an example notebook might look like. cc @ividito.

Checklist

  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • Examples have been updated to reflect changes, if applicable
  • Changes are added to the CHANGELOG, if applicable

@gadomski gadomski self-assigned this Sep 18, 2023
jsignell
jsignell approved these changes Sep 19, 2023
View reviewed changes
Copy link
Collaborator

@jsignell jsignell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Could you base the path off the location of this file rather than cwd?

docs/example.ipynb Outdated Show resolved Hide resolved
@gadomski @jsignell
Update docs/example.ipynb
86f86cc 
Co-authored-by: Julia Signell <[email protected]>
@gadomski
Copy link
Contributor Author

Could you base the path off the location of this file rather than cwd?

Not according to SO 😞: https://stackoverflow.com/a/52119628/732529

@gadomski gadomski enabled auto-merge (squash) September 19, 2023 19:28
@gadomski gadomski merged commit b728832 into main Sep 19, 2023
5 checks passed
@gadomski gadomski deleted the issues/81-docs branch September 19, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsignell jsignell jsignell approved these changes

Assignees

@gadomski gadomski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an example notebook that demonstrates use of the item
2 participants
@gadomski @jsignell