Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging for update fails #140

Open
amouat opened this issue Jun 4, 2024 · 3 comments
Open

Add logging for update fails #140

amouat opened this issue Jun 4, 2024 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers P2 Nice to fix: non-critical items that should be evaluated and planned during issue triage

Comments

@amouat
Copy link

amouat commented Jun 4, 2024

At the moment it seems Frizbee will just fail silently if it can't get a digest e.g. because of auth or network issues. I think it would be worth logging this to stderr.

For example:

FROM redis:invalid_image_tag

is clearly an image reference, but will just be ignored.

I guess this is the place in the code?

https://github.com/stacklok/frizbee/blob/main/pkg/replacer/replacer.go#L303

@rdimitrov
Copy link
Member

hey, @amouat 👋 Thanks for reaching out!

You're right, logging that message might be handy 👍 Feel free to open a PR in case you already have one 😃

@rdimitrov rdimitrov added the enhancement New feature or request label Jun 4, 2024
@evankanderson evankanderson added P2 Nice to fix: non-critical items that should be evaluated and planned during issue triage good first issue Good for newcomers labels Aug 27, 2024
@blkt
Copy link
Contributor

blkt commented Oct 29, 2024

Hi @amouat I'm reaching out to check if this is still relevant to you.
We gladly accept contributions that improve the user experience, so feel free to open a PR if you want!

@amouat
Copy link
Author

amouat commented Oct 30, 2024

I still think it makes sense, yes.

I'm not actively using frizbee right now, so I don't have a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers P2 Nice to fix: non-critical items that should be evaluated and planned during issue triage
Projects
None yet
Development

No branches or pull requests

4 participants