Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation warning for pod enricher #297

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Oct 30, 2024

Description

See #292

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Preview Give feedback
No tasks being tracked yet.

Reviewer

Preview Give feedback

Acceptance

Preview Give feedback

@nightkr nightkr requested a review from a team October 30, 2024 09:13
@nightkr nightkr added this pull request to the merge queue Oct 30, 2024
Merged via the queue into main with commit eb3c244 Oct 30, 2024
17 checks passed
@nightkr nightkr deleted the deprecation/pod-enricher branch October 30, 2024 12:46
@lfrancke
Copy link
Member

lfrancke commented Nov 5, 2024

Can you please add a snippet we can use for the release notes?

@nightkr
Copy link
Member Author

nightkr commented Nov 5, 2024

Pod Enrichment is now deprecated, and will be removed in the next release. Once removed, the SDP will no longer set any enrichment.stackable.tech/ annotations on Pods.

@lfrancke lfrancke added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/2024-11 release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
Development

Successfully merging this pull request may close these issues.

3 participants