fix(MessageValidation): first slot proposals [stage] #1886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test TBD |
y0sher
reviewed
Nov 28, 2024
| @@ -155,7 +155,7 @@ func (mv *messageValidator) validatePartialSigMessagesByDutyLogic( | |||
| } | |||
| } | |||
|
|
|||
| if err := mv.validateBeaconDuty(signedSSVMessage.SSVMessage.GetID().GetRoleType(), messageSlot, committeeInfo.indices); err != nil { | |||
| if err := mv.validateBeaconDuty(role, messageSlot, committeeInfo.indices, &partialSignatureMessages.Type); err != nil { | |||
There was a problem hiding this comment.
following the above comment
Suggested change
| if err := mv.validateBeaconDuty(role, messageSlot, committeeInfo.indices, &partialSignatureMessages.Type); err != nil { | |
| if err := mv.validateBeaconDuty(role, messageSlot, committeeInfo.indices, &partialSignatureMessages.Type == spectypes.RandaoPartialSig); err != nil { |
y0sher
reviewed
Nov 28, 2024
message/validation/common_checks.go
Outdated
| // Rule: For a proposal duty message, we check if the validator is assigned to it | ||
| if role == spectypes.RoleProposer { | ||
| epoch := mv.netCfg.Beacon.EstimatedEpochAtSlot(slot) | ||
| if partialMessageType != nil && *partialMessageType == spectypes.RandaoPartialSig { |
There was a problem hiding this comment.
following other comments
Suggested change
| if partialMessageType != nil && *partialMessageType == spectypes.RandaoPartialSig { | |
| if rando && !mv.dutyStore.Proposer.IsEpochSet(epoch) { |
y0sher
reviewed
Nov 28, 2024
message/validation/common_checks.go
Outdated
| @@ -117,10 +117,20 @@ func (mv *messageValidator) validateBeaconDuty( | |||
| role spectypes.RunnerRole, | |||
| slot phase0.Slot, | |||
| indices []phase0.ValidatorIndex, | |||
| partialMessageType *spectypes.PartialSigMsgType, | |||
There was a problem hiding this comment.
I feel this could be just replaced with a boolean? and do the check outside. since you only use it to see if its a randao message. this could just be randao bool
y0sher
requested changes
Nov 28, 2024
nkryuchkov
changed the title
nkryuchkov
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1827
Solution:
Don't ignore first slot proposal pre-consensus messages (randao) as long as the ProposerHandler has not fetched the duties.
The impact of this change from an attack perspective is minor, as the attacker must be part of the committee (i.e., possess a private key)