You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jun 10, 2018. It is now read-only.
This is a mirror of a bug on Sprockets as it affects either.
The problem is this: EjsTemplatepasses data to EJS.compile which uses gsub! in its implementation. When used with Rails, data is an ActiveSupport::SafeBuffer whose gsub!is messed up at the moment and breaks $1, so the EJS compiling fails.
Should EjsTemplate force data to be a regular string with to_str or should that be EJS's job to make sure the input is a regular string?
I've made a committed fix on ruby-ejs' end for now quick use. If that's the best place to convert SafeBuffers to strings, I can just make a pull request or you can pick a cherry.
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
This is a mirror of a bug on Sprockets as it affects either.
The problem is this:
EjsTemplate
passes data toEJS.compile
which usesgsub!
in its implementation. When used with Rails, data is anActiveSupport::SafeBuffer
whosegsub!
is messed up at the moment and breaks$1
, so the EJS compiling fails.Should EjsTemplate force
data
to be a regular string withto_str
or should that be EJS's job to make sure the input is a regular string?I've made a committed fix on ruby-ejs' end for now quick use. If that's the best place to convert SafeBuffers to strings, I can just make a pull request or you can pick a cherry.
The text was updated successfully, but these errors were encountered: