This repository has been archived by the owner on Jun 10, 2018. It is now read-only.
fix the database generator and Number#valid? #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patterns fix the Number#valid? method to always check for all possible valid number patterns
|
@sstephenson any thoughts on this PR? |
|
👍 |
|
@sstephenson Handle the pending PRs please! These guys had done great job. |
|
@sstephenson @josh ping |
|
Hi @josh and @sstephenson! This project has been tremendously helpful for a few problems we needed to solve. Thanks very much for sharing it. Are there any needed changes you would like to see in this pull request? It would be awesome if someone could give us some feedback. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1