global_phone_dbgen --test doesn't always generate valid phone numbers #1

rubemz · 2013-06-10T22:20:43Z

An easy way to see this error happening is adding to this test case the following assertion (since its fixture was generated by global_phone_dbgen --test):

assert number.valid?, "expected #{string} be valid for territory #{territory_name}"

And looks like this error is happening because for some country codes the phone formats are missing.

I'm hoping to use the generated list of phones as fixture to my tests, but it would need to always have valid phone numbers generated.

These additions have been made - * Ability to parse a phone number without territory being supplied. * Ability to determine the type of the phone number. Possible types are - :fixed_line, :mobile, :fixed_line_or_mobile, :toll_free, :premium_rate, ... * Methods to check if a number is fixed_line or mobile. If the type of the number is :fixed_line_or_mobile then both these methods will return true in such a case.

rubemz linked a pull request Jun 11, 2013 that will close this issue

fix the database generator and Number#valid? #2

Open

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

global_phone_dbgen --test doesn't always generate valid phone numbers #1

global_phone_dbgen --test doesn't always generate valid phone numbers #1

rubemz commented Jun 10, 2013

global_phone_dbgen --test doesn't always generate valid phone numbers #1

global_phone_dbgen --test doesn't always generate valid phone numbers #1

Comments

rubemz commented Jun 10, 2013