Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernization (Structure, Coding Style etc...) #2

Open
a4lg opened this issue Sep 18, 2017 · 0 comments
Open

Modernization (Structure, Coding Style etc...) #2

a4lg opened this issue Sep 18, 2017 · 0 comments
Assignees
Milestone

Comments

@a4lg
Copy link
Collaborator

a4lg commented Sep 18, 2017

ssdeep needs modernization. Because this program has long history, some part of the code is getting old. As a part of major program restructuring, I'm doing some modernization.

  • Coding style changes
    To make program consistent, easy to read and easy to contribute, coding style of ssdeep will be updated to relatively major one.
  • Deprecating some language features
    ssdeep uses some features on C/C++ language that are inconsistent and make the program confusing. Uses of those features will be removed.
  • Portability improvements
    Except some library part, I'm going to make the program portable as possible.
  • Readability improvements

Coding Style Changes

  • 1 indent == 4 spaces
  • no tabs
  • similar to K&R
  • basically limited to 78 columns (but with exceptions)

Deprecateing Language Features

  • Alternative operators (and, or and not)
    Use &&, || and !.

Portability

  • Portable integer types
    Some uses of non-portable types (uint8_t and uint64_t) will be changed to make the program portable. Note that uint32_t argument of fuzzy_hash_buf will be preserved for now.
@a4lg a4lg added this to the Version 2.15 milestone Sep 18, 2017
@a4lg a4lg self-assigned this Sep 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant