From 7b99269c7c9ef2e6178d84670a63568ec7dfdbdf Mon Sep 17 00:00:00 2001 From: Legendaxe <102746941+Legendaxe@users.noreply.github.com> Date: Mon, 16 Oct 2023 18:59:23 +0300 Subject: [PATCH 1/2] fix live mobs --- modular_ss220/credits/code/SScredits.dm | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/modular_ss220/credits/code/SScredits.dm b/modular_ss220/credits/code/SScredits.dm index 47e34176dba3..a442c6ebc495 100644 --- a/modular_ss220/credits/code/SScredits.dm +++ b/modular_ss220/credits/code/SScredits.dm @@ -82,11 +82,10 @@ SUBSYSTEM_DEF(credits) continue if(!human.last_known_ckey) continue - if(!human.client?.holder) - continue - if(human.client.holder.rank == "Банда") - streamers += "
[human.real_name]([human.ckey]) в роли [human.job]
" - continue + if(human.client?.holder) + if(human.client.holder.rank == "Банда") + streamers += "
[human.real_name]([human.ckey]) в роли [human.job]
" + continue if(!length(cast) && !chunksize) chunk += "В съемках участвовали:" chunk += "[human.real_name] в роли [uppertext(human.job)]" @@ -113,7 +112,7 @@ SUBSYSTEM_DEF(credits) corpses += human.real_name if(length(corpses)) - titles += "
Основано на реальных событиях
В память о [english_list(corpses)].
" + titles += "
Основано на реальных событиях:
В память о [english_list(corpses)].

" var/list/staff = list("Съемочная группа:") var/list/staffjobs = file2list("config/credits/jobs/staffjobs.txt") From 7bf00ae253159450a9fa0f00bbaf071242324f78 Mon Sep 17 00:00:00 2001 From: Legendaxe <102746941+Legendaxe@users.noreply.github.com> Date: Mon, 16 Oct 2023 19:07:45 +0300 Subject: [PATCH 2/2] gaxeer review fixed --- modular_ss220/credits/code/SScredits.dm | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/modular_ss220/credits/code/SScredits.dm b/modular_ss220/credits/code/SScredits.dm index a442c6ebc495..d2d9a6ce4509 100644 --- a/modular_ss220/credits/code/SScredits.dm +++ b/modular_ss220/credits/code/SScredits.dm @@ -82,10 +82,9 @@ SUBSYSTEM_DEF(credits) continue if(!human.last_known_ckey) continue - if(human.client?.holder) - if(human.client.holder.rank == "Банда") - streamers += "
[human.real_name]([human.ckey]) в роли [human.job]
" - continue + if(human.client?.holder?.rank == "Банда") + streamers += "
[human.real_name]([human.ckey]) в роли [human.job]
" + continue if(!length(cast) && !chunksize) chunk += "В съемках участвовали:" chunk += "[human.real_name] в роли [uppertext(human.job)]"