Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom welding helmet to loadout #1728

Merged
merged 3 commits into from
Jan 11, 2025

Conversation

m-dzianishchyts
Copy link
Collaborator

@m-dzianishchyts m-dzianishchyts commented Jan 4, 2025

Что этот PR делает

Добавляет еще одну маску для сварки, которую мне запретили добавлять на апстриме, потому что она какая-то донатно-персональная. Но мы этим не обременены, так что можно.

Почему это хорошо для игры

Красивая маска за донат.

Тестирование

По аналогии с другими масками, так что верю

Changelog

🆑 Maxiemar
tweak: В лодаут добавлена еще одна сварочная маска с особой раскраской.
/:cl:

Summary by Sourcery

New Features:

  • A new "Red flame decal welding helmet" has been added to the donor loadout.

Copy link

sourcery-ai bot commented Jan 4, 2025

Reviewer's Guide by Sourcery

This pull request adds a new cosmetic welding helmet with a red flame decal to the donor loadout.

Class diagram for the new donor welding helmet

classDiagram
    class datum_gear_donor {
        +display_name: string
        +path: string
        +allowed_roles: list
        +donator_tier: int
        +cost: int
    }
    class welding_redflame {
        +display_name: "Red flame decal welding helmet"
        +path: /obj/item/clothing/head/welding/flamedecal
        +allowed_roles: ["Chief Engineer", "Station Engineer", "Life Support Specialist", "Roboticist"]
        +donator_tier: 2
        +cost: 2
    }
    datum_gear_donor <|-- welding_redflame
    note for welding_redflame "New donor welding helmet
with red flame decal"
Loading

File-Level Changes

Change Details Files
Added a new donor item: Red Flame Decal Welding Helmet
  • A new datum, /datum/gear/donor/welding_redflame, has been added.
  • The new helmet has the display name "Red flame decal welding helmet".
  • It uses the object path /obj/item/clothing/head/welding/flamedecal.
  • It is allowed for Chief Engineer, Station Engineer, Life Support Specialist, and Roboticist roles.
  • It has a donor tier of 2 and a cost of 2.
modular_ss220/loadout/code/donor.dm

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions github-actions bot added the :finnadie: НЕ МОДУЛЬНО Па-ху-ю. label Jan 4, 2025
@m-dzianishchyts m-dzianishchyts marked this pull request as draft January 5, 2025 12:06
@github-actions github-actions bot added :feelsgood: Частичная модульность Не всегда получается всё впихнуть в модуль, увы. and removed :finnadie: НЕ МОДУЛЬНО Па-ху-ю. labels Jan 11, 2025
@github-actions github-actions bot removed the :feelsgood: Частичная модульность Не всегда получается всё впихнуть в модуль, увы. label Jan 11, 2025
@m-dzianishchyts m-dzianishchyts marked this pull request as ready for review January 11, 2025 12:19
@m-dzianishchyts m-dzianishchyts merged commit 218b188 into ss220club:master Jan 11, 2025
15 of 23 checks passed
@m-dzianishchyts m-dzianishchyts deleted the welding-helmet-gear branch January 11, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants