Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The last element in the list is not shown if the overflow appears. #11

Open
coderwassananmol opened this issue Oct 5, 2017 · 6 comments

Comments

@coderwassananmol
Copy link
Contributor

No description provided.

@andrey-semin
Copy link

is anyone on it already? i'd like to take it

@StanleySathler
Copy link
Member

Hello @andrey-semin,
Be welcome to our repository! Uhul!

Probably, @coderwassananmol is already working on it. But you can choose any other issue that you'd like to give a try too. Your contribution is welcome. 😄

@andrey-semin
Copy link

Let me take #5 and #8 if possible

@StanleySathler
Copy link
Member

@andrey-semin they're all yours.

coderwassananmol added a commit to coderwassananmol/jquery-sth-select that referenced this issue Oct 5, 2017
StanleySathler added a commit that referenced this issue Oct 8, 2017
@StanleySathler
Copy link
Member

Fixed by @coderwassananmol. 👍

@StanleySathler
Copy link
Member

Hello @coderwassananmol

I had made a mistake. When accepted your pull request, I didn't see that you changed only the dist file (/dist/js/sth-select.js). So, after running $ gulp command again, your changes were lost.

Your code is 100% correct. The only problem is that you must modify the file /src/js/_popup.js and then run the $ gulp command in your terminal, which generates the file /dist/js/sth-select.js again.

Could you please fix that? You can check the code that you made clicking here.

Peace & Love ✌️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants