Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to Schema Allow Location to have @resp or @source #1201

Open
davidamichelson opened this issue Dec 16, 2019 · 8 comments
Open

Change to Schema Allow Location to have @resp or @source #1201

davidamichelson opened this issue Dec 16, 2019 · 8 comments

Comments

@davidamichelson
Copy link

davidamichelson commented Dec 16, 2019

Instead of requiring @source could we require @resp or @source in TEI:location

@davidamichelson
Copy link
Author

See place 4160 in BQG

@davidamichelson
Copy link
Author

          <location type="nested" resp="http://bqgazetteer.bethmardutho.org">
            <region ref="http://bqgazetteer.bethmardutho.org/place/37">Beth Qaṭraye</region>
          </location>

@dlschwartz
Copy link

@davidamichelson look at line 1859 here and also at line 1862. I think this is what you want but I want to confirm. I will add the same schematron rules (mutatis mutandis) to if you want the same rules to apply there. If you want something different, just let me know.

@davidamichelson
Copy link
Author

Quick question, if I am correct it looks like your schema rule is putting this on TEI:placeName, but we would prefer to require it on TEI:location. Am I misreading?

@dlschwartz
Copy link

It currently exists in placeName. I'll also put it on location if that's what you want. Just make sure you want these rules: either source or resp is required, both source and resp cannot appear together.

@davidamichelson
Copy link
Author

Okay, got it now.

Here is what we would like please.

  1. Require either @source or @resp on TEI:location

  2. But make a new change to placeName now that we are aware of a possible issue. @source or @resp should only be required on TEI:placeName when placeName is the child of TEI:place. When placeName occurs in a TEI:desc for instance we don't want to require @source or @resp (see http://syriaca.org/place/600/tei as an example)

Thanks!

Adding link to issue: srophe/bethqatraye-data#25

@dlschwartz
Copy link

@davidamichelson great. However, see https://github.com/srophe/draft-data/blob/master/data/schemaPlaceDraftData/syriacaPlacesTEI.odd#L1857. The context should already be set to require source or resp on placeName only when it's the child of place. Are you getting an error message when you use a placeName in a desc element?

@dlschwartz
Copy link

@davidamichelson I've implemented this change and pushed it: srophe/draft-data@925e29d.

Test the placeName and location rules in practice. Close this issue if all looks good or let me know if you need changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants