Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template Parameters on Functions with a Templated Namespace are not gathered #5

Open
Joshua2000B opened this issue May 22, 2024 · 3 comments

Comments

@Joshua2000B
Copy link
Member

When defining a template parameter on a function, if the function is in the namespace of a templatable class, the template parameter of the function is not gathered.

template <typename T>
T cls::foo() {}

template <typename R>
R cls<R>::bar() {}

When nameCollector is run on the above code, the output is:

The following 3 user defined identifiers occur:
T is a template-parameter in file: nc_test.cpp at 1:20
foo is a T function in file: nc_test.cpp at 2:8
bar is a R function in file: nc_test.cpp at 5:11

There should be a 4th line, stating:

R is a template-parameter in file: nc_test.cpp at 4:20
@jmaletic
Copy link
Contributor

It is also missing the local variables in the methods defined outside the class.

bool stack::isEmpty() const { int temp = 5; }

temp is not showing up.

@Joshua2000B
Copy link
Member Author

Bug seems to have been introduced from the fix for Issue 3. Previously, functions like ns::foo() would have duplicated entries, one for ns and one for foo. However, functions like cls<T>::foo() would NOT have the duplication, and the fix is not needed in this case.

@jmaletic
Copy link
Contributor

If we had a testsuite and did regression testing it would have been found immediately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants