Skip to content
This repository has been archived by the owner on Sep 11, 2020. It is now read-only.

Test goes fail when git config is not set #1138

Open
jmkim opened this issue Apr 30, 2019 · 0 comments · May be fixed by #1139
Open

Test goes fail when git config is not set #1138

jmkim opened this issue Apr 30, 2019 · 0 comments · May be fixed by #1139

Comments

@jmkim
Copy link
Contributor

jmkim commented Apr 30, 2019

The test goes fail with git exit status 128 while committing when git config is not set globally or locally.

Here is an error log with go test -test.v -check.v -gocheck.v:

----------------------------------------------------------------------
FAIL: worktree_test.go:232: RepositorySuite.TestPullAdd

worktree_test.go:248:
    ExecuteOnPath(c, path,
        "touch foo",
        "git add foo",
        "git commit -m foo foo",
    )
repository_test.go:2540:
    c.Assert(err, IsNil)
... value *exec.ExitError = &exec.ExitError{ProcessState:(*os.ProcessState)(0xc00268de40), Stderr:[]uint8(nil)} ("exit status 128")

OOPS: 253 passed, 1 FAILED

I'll make a patch very soon and will send PR here.
jmkim added a commit to jmkim/go-git that referenced this issue Apr 30, 2019
@jmkim
worktree: Set local user config for reproducible testing
718f985 
The test goes fail with git exit status 128 while committing when git
config is not set globally or locally.

Fixes src-d#1138

Signed-off-by: Jongmin Kim <[email protected]>
@jmkim jmkim linked a pull request Apr 30, 2019 that will close this issue
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

worktree: Set local user config for reproducible testing jmkim/go-git
1 participant
@jmkim